Uh oh!
There was an error while loading. Please reload this page.
feat(container): add ubuntu24-cuda13 image with LLVM 19.1.7 - #386
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
brandonros
commented
May 1, 2026
| fn target_to_llvm_prebuilt(target: &str) -> String { | ||
| let base = match target { | ||
| "x86_64-pc-windows-msvc" => "windows-x86_64", | ||
| // NOTE(RDambrosio016): currently disabled because of weird issues with segfaults and building the C++ shim |
ContributorAuthor
There was a problem hiding this comment.
@LegNeato a little aggressive but also worth an interesting test to see if this is still needed?
brandonros
commented
May 1, 2026
| .join(format!("libintrinsics_v{}.bc", flavor.major)); | ||
| let llvm_as = find_llvm_as(llvm_config, flavor); | ||
| let status = Command::new(&llvm_as) |
ContributorAuthor
There was a problem hiding this comment.
kind of an interesting tradeoff. always recompile the .bc bytecode from the .ll for llvm-v7 or llvm-v19?
brandonrosforce-pushed
the
cuda13-llvm19
branch
2 times, most recently
from
May 2, 2026 13:46
dbdee10 to
29d75acComparebrandonros
marked this pull request as ready for review
May 2, 2026 14:31
brandonros
commented
May 2, 2026
ContributorAuthor
small overlap with #389 |
3 tasks
Collapse the per-LLVM duplication in the build script into a single `LlvmFlavor` struct with two const instances (LLVM7, LLVM19). One `find_llvm_config`, `find_llvm_as`, `configure_libintrinsics`, and `rustc_llvm_build` now drive both toolchain paths; `required_major_llvm_version`, `find_llvm_config_llvm7`, `find_llvm_config_llvm19`, and `find_llvm_as_llvm19` are gone. Functional changes that fall out of the refactor: - Prebuilt LLVM download now works for the `llvm19` feature too, gated on `USE_PREBUILT_LLVM=1` or as an automatic fallback when no LLVM 19 toolchain is found locally. New `PREBUILT_LLVM_URL_LLVM19` points at the `llvm-19.1.7` release tag. - Prebuilt download now supports `linux-x86_64` and `linux-aarch64` in addition to `windows-x86_64`. The "currently disabled because of segfaults" note on Linux x86_64 is gone — the prebuild repos that produce these archives have been refactored to fix the underlying issue. - `PREBUILT_LLVM_URL_LLVM7` retagged to lowercase `llvm-7.1.0/` to match the new release-tag scheme used by the prebuild repos. - `libintrinsics.bc` is no longer checked in; both LLVM versions now assemble `libintrinsics.ll` on the fly using the `llvm-as` that ships next to the resolved `llvm-config`. Removes the only remaining version-specific branch and means the LLVM 7 path can no longer drift silently when the `.ll` changes. The LLVM 7 candidate-search behavior is also slightly stricter: previously `LLVM_CONFIG` only had to literally start with "7" (matching 7, 70, 700...) and a mismatched env var skipped straight to download; now major-version match is exact and PATH `llvm-config` is tried as a fallback before downloading. `USE_PREBUILT_LLVM=1` still forces direct download. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
3 tasks
brandonros
commented
Aug 11, 2026
ContributorAuthor
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #385