Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 117
spirv_builder feature compile_codegen to disable building rustc_codegen_spirv#245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
30c6502a30c580dd056a37e3a7b549a962b1c0baeefe42c46674214b879338bbb5d2e05235161de2cef8d643a656a518ac744c8449a9ebc1da624d1b619665dcbdc52e040ab9b8f659beca83df5db761e3c9a7d774d1c66d8f0398File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -4,3 +4,4 @@ target/ | ||
| tests/Cargo.lock | ||
| .github/install-spirv-tools/Cargo.lock | ||
| rustc-ice-*.txt | ||
| .idea | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really annoying, can this constraint be lifted now that the toolchain was upgraded? This prevents me from using newer clap version in the workspace downstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to remember that I pinned that. Running
cargo-gpuagainst newerrust-gpuversions was failing.cargo-gpuhas tests for the last ~2 years ofrust-gpuversions. So if you want to bumpclap, andcargo-gputests pass then I think it's fine. And if they fail, then what @schell and I discussed is thatcargo-gpushould aim to support the last 2 versions ofrust-gpu. But I'm sure that could be relaxed if there's good reason.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that you no longer directly depend on old spirv-builder versions since I refactored cargo-gpu, we always use the newest one. Only the codegen backend is now compiled in a potentially quite old toolchain, which doesn't need clap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already updated in #349, everything looks good so far