Skip to content

add spirv-unknown-naga-wgsl target via naga - #280

Closed
Firestar99 wants to merge 6 commits into
target_env_enumfrom
naga
Closed

add spirv-unknown-naga-wgsl target via naga#280
Firestar99 wants to merge 6 commits into
target_env_enumfrom
naga

Conversation

@Firestar99

@Firestar99Firestar99 commented Jun 11, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Requires #309#310#311

This was referenced Jun 11, 2025
Closed
Closed
@Firestar99
Firestar99force-pushed the naga branch 4 times, most recently from 016845f to 6696b4fCompareJune 13, 2025 08:48
@Firestar99Firestar99 changed the title add wgsl-unknown-unknown target via nagaadd spirv-unknown-wgsl target via nagaJun 13, 2025
@Firestar99
Firestar99force-pushed the naga branch 9 times, most recently from ca183f5 to 7ff21a6CompareJune 16, 2025 09:49
@Firestar99
Firestar99force-pushed the naga branch 2 times, most recently from 4235871 to 03eac2fCompareJune 22, 2025 12:32
@LegNeato

LegNeato commented Jun 22, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

I think this is fine and later when we change it to have something generic like "gpu" we can document it / support the old style as well. Do you think instead it should be spirv-[unknown-]naga-wgsl or spirv-[unknown-]wgpu-wgsl? Probably not but wanted to check in case you hadn't thought of those options and they are more appropriate. I doubt we'd have another or "pure" wgsl backend for a long time.

@Firestar99

Firestar99 commented Jun 22, 2025

Copy link
Copy Markdown
MemberAuthor

I actually think we should add naga to the target, since we could be having a *-naga-glsl and a *-cross-glsl target via spirv-cross

This was referenced Jul 1, 2025
Merged
Merged
Closed
@Firestar99
Firestar99 changed the base branch from main to target_env_enumJuly 2, 2025 08:40
@Firestar99
Firestar99force-pushed the target_env_enum branch 2 times, most recently from bede829 to 36e9997CompareJuly 11, 2025 16:31
@Firestar99
Firestar99force-pushed the naga branch 3 times, most recently from f0aeca3 to 9943c55CompareJuly 11, 2025 16:58
@Firestar99Firestar99 changed the title add spirv-unknown-wgsl target via nagaadd spirv-unknown-naga-wgsl target via nagaJul 11, 2025
@Firestar99Firestar99 mentioned this pull request Jul 11, 2025
Closed
@Firestar99

Firestar99 commented Jul 11, 2025

Copy link
Copy Markdown
MemberAuthor

It has been renamed to spirv-unknown-naga-wgsl and should be quite usable already. There's still a bunch of failing compiletests due to naga not parsing some spv structure properly, they should either be ignored or checked upon before merging. May just opt for ignoring them all and fixing them up at a later date.

Nice side effect of naming it naga-wgsl: compiletest can be ignored with ignore-naga so any future naga targets will also be ignored.

@Firestar99
Firestar99force-pushed the naga branch 2 times, most recently from 63f251d to c2bef95CompareJuly 25, 2025 11:09
@Firestar99Firestar99 mentioned this pull request Aug 11, 2025
Merged
@Firestar99Firestar99 mentioned this pull request Dec 17, 2025
Merged
@Firestar99

Firestar99 commented Dec 17, 2025

Copy link
Copy Markdown
MemberAuthor

Superseded by #493

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddybeddybAwaiting requested review from eddybeddyb will be requested when the pull request is marked ready for revieweddyb is a code owner
@LegNeatoLegNeatoAwaiting requested review from LegNeatoLegNeato will be requested when the pull request is marked ready for reviewLegNeato is a code owner
@schellschellAwaiting requested review from schellschell will be requested when the pull request is marked ready for reviewschell is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Firestar99@LegNeato