Uh oh!
There was an error while loading. Please reload this page.
ci: enable clippy for more crates - #329
Merged
Merged
Conversation
Firestar99
marked this pull request as ready for review
July 11, 2025 09:56
Firestar99
enabled auto-merge
July 11, 2025 09:57
eddyb
approved these changes
Jul 11, 2025
eddyb
left a comment
Member
There was a problem hiding this comment.
Hmpf, unfortunate that we can't pass the features somehow, to a single cargo clippy --workspace invocation.
Alternatively, it might be nice to not have SPIRV-Tools' C++ code be compiled by spirv-tools-rs when built for cargo check/cargo clippy, but I don't recall if that's even feasible to do.
Firestar99
commented
Jul 11, 2025
MemberAuthor
I mean, you should be able to detect clippy in the build script and return. Currently, using cargo-gpu in a build script will fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clippy doesn't run on eg. compiletest and difftest and there's some code it's complaining about