Uh oh!
There was an error while loading. Please reload this page.
ci: switch to jakoch/install-vulkan-sdk-action@v1 for Vulkan SDK + SwiftShader. - #400
Conversation
81f9437 to
ea055baCompareNcStudios/VulkanCI@v1.2.NcStudios/VulkanCI@v1.2.NcStudios/VulkanCI@v1.2.jakoch/install-vulkan-sdk-action@v1 for Vulkan SDK + SwiftShader.ea055ba to
a6529a0Comparea6529a0 to
c60381eCompare
Firestar99
left a comment
There was a problem hiding this comment.
Seems quite dead to me: NcStudios/VulkanCI#11
I was going to mention that the repo only has 10 stars, but NcStudios has 27 and humbletim has 55. It seems all github actions have a very low star rating.
Uh oh!
There was an error while loading. Please reload this page.
eddyb
commented
Sep 19, 2025
That's really weird, merge queue failed in the same way having no SwiftShader used to fail, but it clearly works in PR CI, and I can definitely see the failing run having executed: echo"C:/Swiftshader/">>"$GITHUB_PATH"echo"VK_DRIVER_FILES=C:/Swiftshader/vk_swiftshader_icd.json">>"$GITHUB_ENV"(which is needed to actually use SwiftShader - Anyway, it worked in PR CI, so I am going to retry it, hoping I am not making CI non-deterministic in the process. |
Updating the Vulkan SDK we used in CI came up in:
Offset/ArrayStride) when disallowed by Vulkan. #379 (comment)Sadly, the
NcStudios/VulkanCI@v1.2action we were using to get SwiftShader on Windows, is stuck on an older version, and doesn't appear to be prompt to update in general.So this PR replaces
humbletim/install-vulkan-sdk@v1.2+NcStudios/VulkanCI@v1.2withjakoch/install-vulkan-sdk-action@v1, which supports SwiftShader (or Lavapipe, but I kept it on SwiftShader) for Windows (AFAICT that action downloads SwiftShader/Lavapipe releases fromjakoch/rasterizers, separately from the Vulkan SDK).From what I could tell, the
jakoch/install-vulkan-sdk-actionrepo has a lot more recent activity than the others we were using, and its approach feels more robust long-term (at least in terms of bumping Vulkan SDK versions).