Skip to content

ci: switch to jakoch/install-vulkan-sdk-action@v1 for Vulkan SDK + SwiftShader. - #400

Merged
eddyb merged 2 commits into
Rust-GPU:mainfrom
LykenSol:ci-windows-swiftshader
Sep 19, 2025
Merged

ci: switch to jakoch/install-vulkan-sdk-action@v1 for Vulkan SDK + SwiftShader.#400
eddyb merged 2 commits into
Rust-GPU:mainfrom
LykenSol:ci-windows-swiftshader

Conversation

@eddyb

@eddybeddyb commented Sep 18, 2025

Copy link
Copy Markdown
Member

Updating the Vulkan SDK we used in CI came up in:

Sadly, the NcStudios/VulkanCI@v1.2 action we were using to get SwiftShader on Windows, is stuck on an older version, and doesn't appear to be prompt to update in general.

So this PR replaces humbletim/install-vulkan-sdk@v1.2 + NcStudios/VulkanCI@v1.2 with jakoch/install-vulkan-sdk-action@v1, which supports SwiftShader (or Lavapipe, but I kept it on SwiftShader) for Windows (AFAICT that action downloads SwiftShader/Lavapipe releases from jakoch/rasterizers, separately from the Vulkan SDK).

From what I could tell, the jakoch/install-vulkan-sdk-action repo has a lot more recent activity than the others we were using, and its approach feels more robust long-term (at least in terms of bumping Vulkan SDK versions).

@eddyb
eddybforce-pushed the ci-windows-swiftshader branch 3 times, most recently from 81f9437 to ea055baCompareSeptember 18, 2025 16:07
@eddybeddyb changed the title [WIP] ci: get SwiftShader working on Windows without needing NcStudios/VulkanCI@v1.2.ci: use SwiftShader on Windows without needing NcStudios/VulkanCI@v1.2.Sep 18, 2025
@eddybeddyb changed the title ci: use SwiftShader on Windows without needing NcStudios/VulkanCI@v1.2.ci: switch to jakoch/install-vulkan-sdk-action@v1 for Vulkan SDK + SwiftShader.Sep 18, 2025
@eddyb
eddyb marked this pull request as ready for review September 18, 2025 16:46
@eddyb
eddybforce-pushed the ci-windows-swiftshader branch from ea055ba to a6529a0CompareSeptember 18, 2025 16:46
@eddyb
eddybforce-pushed the ci-windows-swiftshader branch from a6529a0 to c60381eCompareSeptember 18, 2025 16:48
@eddyb
eddyb enabled auto-merge September 18, 2025 16:48

@Firestar99Firestar99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems quite dead to me: NcStudios/VulkanCI#11

I was going to mention that the repo only has 10 stars, but NcStudios has 27 and humbletim has 55. It seems all github actions have a very low star rating.

@eddyb
eddyb added this pull request to the merge queueSep 18, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Sep 18, 2025
@eddyb

Copy link
Copy Markdown
MemberAuthor

That's really weird, merge queue failed in the same way having no SwiftShader used to fail, but it clearly works in PR CI, and I can definitely see the failing run having executed:

echo"C:/Swiftshader/">>"$GITHUB_PATH"echo"VK_DRIVER_FILES=C:/Swiftshader/vk_swiftshader_icd.json">>"$GITHUB_ENV"

(which is needed to actually use SwiftShader - NcStudios/VulkanCI@v1.2 was doing that automatically, but for jakoch/install-vulkan-sdk-action@v1 I had to do it manually)

Anyway, it worked in PR CI, so I am going to retry it, hoping I am not making CI non-deterministic in the process.

@eddyb
eddyb added this pull request to the merge queueSep 19, 2025
Merged via the queue into Rust-GPU:main with commit 9451cdeSep 19, 2025
13 checks passed
@eddyb
eddyb deleted the ci-windows-swiftshader branch September 19, 2025 05:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@eddyb@Firestar99