Skip to content

Examples improvements - #402

Merged
Firestar99 merged 4 commits into
Rust-GPU:mainfrom
nnethercote:examples-improvements
Sep 22, 2025
Merged

Examples improvements#402
Firestar99 merged 4 commits into
Rust-GPU:mainfrom
nnethercote:examples-improvements

Conversation

@nnethercote

@nnethercotennethercote commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Some improvements to the examples, mostly docs, a little code. Details in the individual commits.

@nnethercote
Improve the documentation of the compute shader example.
99662f2
Also make it include `1` in the output sequence, because that is the
first number according to https://oeis.org/A006877.
@nnethercote
Change the intensity keys in the sky-on-shader example.
32667ea
Currently you can use '+'/'-' on the numeric keypad to adjust the
intensity, but lots of keyboards lack a numeric keypad. This commit
changes it to use the up and down arrows instead.
eddyb
eddyb reviewed Sep 19, 2025
View reviewed changes
Comment threadexamples/runners/ash/src/main.rs
eddyb
eddyb requested changes Sep 19, 2025
View reviewed changes

@eddybeddyb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, no real complaints, just a bunch of nitpicks (feel free to ignore most of them tbh), and being reminded of things I'd forgotten about, heh.

Comment threadexamples/README.md Outdated
Comment threadexamples/README.md Outdated
Comment threadexamples/README.md Outdated
Comment threadexamples/README.md Outdated
Comment threadexamples/README.md Outdated
Comment threadexamples/README.md
@nnethercote
nnethercoteforce-pushed the examples-improvements branch 4 times, most recently from be36be9 to 3a8f4baCompareSeptember 21, 2025 22:46
@nnethercote
Improve examples documentation.
a373bdc
Better explain the shaders and runners, and explain how to invoke them,
and even document the `+`/`-` feature of the sky shader on ash, which
is currently invisible unless you read the code.
@nnethercote

nnethercote commented Sep 21, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review. I have fixed the addressable ones. Should be good to go, now.

@eddyb
eddyb added this pull request to the merge queueSep 22, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@Firestar99
Firestar99 added this pull request to the merge queueSep 22, 2025
@Firestar99

Firestar99 commented Sep 22, 2025

Copy link
Copy Markdown
Member

Intermittent Internet failure: connection reset

Merged via the queue into Rust-GPU:main with commit b6c42beSep 22, 2025
13 checks passed
@nnethercote
nnethercote deleted the examples-improvements branch September 22, 2025 23:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddybeddybeddyb approved these changes
@LegNeatoLegNeatoAwaiting requested review from LegNeatoLegNeato is a code owner
@Firestar99Firestar99Awaiting requested review from Firestar99Firestar99 is a code owner
@schellschellAwaiting requested review from schell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nnethercote@Firestar99@eddyb