Skip to content

Debug for CargoCmd - #415

Merged
LegNeato merged 1 commit into
Rust-GPU:mainfrom
tuguzT:spirv-builder-cargo-cmd-debug
Sep 29, 2025
Merged

Debug for CargoCmd#415
LegNeato merged 1 commit into
Rust-GPU:mainfrom
tuguzT:spirv-builder-cargo-cmd-debug

Conversation

@tuguzT

@tuguzTtuguzT commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

Fix CargoCmd to implement Debug instead of Display (which was presumably a typo).
Also implement From<CargoCmd> for Command which will be useful a bit later (as a part of Rust-GPU/cargo-gpu#112).

@tuguzTtuguzT mentioned this pull request Sep 28, 2025
Closed
LegNeato
LegNeato approved these changes Sep 29, 2025
View reviewed changes

@LegNeatoLegNeato left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LegNeato
LegNeato added this pull request to the merge queueSep 29, 2025
Merged via the queue into Rust-GPU:main with commit 929112aSep 29, 2025
13 checks passed
@tuguzT
tuguzT deleted the spirv-builder-cargo-cmd-debug branch September 29, 2025 08:33
@Firestar99

Firestar99 commented Sep 29, 2025

Copy link
Copy Markdown
Member

thanks, that one is on me

@tuguzTtuguzT mentioned this pull request Oct 1, 2025
Closed
@Firestar99Firestar99 mentioned this pull request Dec 4, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LegNeatoLegNeatoLegNeato approved these changes
@eddybeddybAwaiting requested review from eddybeddyb is a code owner
@Firestar99Firestar99Awaiting requested review from Firestar99Firestar99 is a code owner
@schellschellAwaiting requested review from schell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tuguzT@Firestar99@LegNeato