Uh oh!
There was an error while loading. Please reload this page.
Compiletest: pass -Zui-testing to rustc - #447
Conversation
nnethercote
commented
Oct 21, 2025
I would squash together the 2nd and 3rd commits because they don't make sense in isolation (tests will fail if just the 2nd commit is applied). Otherwise, I'm not a rust-gpu reviewer, but LGTM. |
Firestar99
commented
Oct 21, 2025
I was considering it, but didn't as it "hides" the " |
18c92d8 to
067b38bComparennethercote
commented
Oct 21, 2025
It's mentioned in the first line of the commit message! :) |
LegNeato
left a comment
There was a problem hiding this comment.
Sweet! Thanks for doing this.
This is the dual of Rust-GPU/rust-gpu#447
Uh oh!
There was an error while loading. Please reload this page.
This is the dual of Rust-GPU/rust-gpu#447
eddyb
left a comment
There was a problem hiding this comment.
To be perfectly honest, seeing this diff, the fact that we weren't using -Z ui-testingfor the kind of tests named ui because of rustc testing infrastructure, is quite the facepalm moment 🤦.
Thanks for cleaning this up!
Supersedes #439, see discussions over there
-Zui-testingto rustc to improve compiletest normalization and have fewer conflicts