Uh oh!
There was an error while loading. Please reload this page.
Spirv builder cleanup - #497
Conversation
0a13b82 to
80842c0Compare80842c0 to
94a23d2Compare94a23d2 to
43324feCompare| #[error("some metadata file is missing")] | ||
| MetadataFileMissing(#[from] std::io::Error), | ||
| #[error("unable to parse multi-module metadata file")] | ||
| #[error("unable to parse some metadata file")] |
There was a problem hiding this comment.
It would be better to have two variants here for the single and multi-module case to make the message more explicit and the message better?
There was a problem hiding this comment.
The error message on main is completely wrong: There are no "multi-module" metadata files. The metadata file is needed regardless of the module being a multi-module or single module, as it contains all entry point names and *.spv paths which are returned to you after building.
In fact there are four cases MetadataFileMissing will be emitted on main:
parse_metadata_file: The metadata file is missing, staysMetadataFileMissing. Can also fail withMetadataFileMalformed.leaf_depsfails to read rustc dependency information files, nowDepFileParseError.query_rustc_versionfails to query the rustc version, now genericIoError.TargetSpecVersion::target_argfails to write the target spec file, now genericIoError.
The new error messages:
rust-gpu/crates/spirv-builder/src/lib.rs
Lines 120 to 125 in a292dc3
rust-gpu/crates/spirv-builder/src/lib.rs
Lines 135 to 136 in a292dc3
a292dc3 to
6af1e33Compare6af1e33 to
b651341CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
b651341 to
23d07d9CompareFirestar99
commented
Jul 13, 2026
Oops, find replace was a little too aggressive there... squashed it in |
Uh oh!
There was an error while loading. Please reload this page.
Firestar99
commented
Jul 13, 2026
Force-merged since review from LegNeato is blocking it |
Requires #484#488#496