Skip to content

[#25] Added PyVer Crate - #27

Open
Allstreamer wants to merge 6 commits into
developfrom
25-add-python-version-parsing-pep-440
Open

[#25] Added PyVer Crate#27
Allstreamer wants to merge 6 commits into
developfrom
25-add-python-version-parsing-pep-440

Conversation

@Allstreamer

@AllstreamerAllstreamer commented Aug 15, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Add PyVer crate to project

Based on:

image
PEP-440 Docs

Example Usage

use pyver::PackageVersion;let one = PackageVersion::new("v1.0");let two = PackageVersion::new("2.0");assert_eq!(true, two > one)

Commits

@Allstreamer
Moved changes from#20
19abbd9
- Moved changes from #20 to 25-add-python-version-parsing-pep-440 branch
@AllstreamerAllstreamer added documentation Improvements or additions to documentation new feature New feature or request labels Aug 15, 2022
@AllstreamerAllstreamer self-assigned this Aug 15, 2022
@AllstreamerAllstreamer changed the title [#25] Python versioning System[#25] Python versioning SystemAug 15, 2022
@Allstreamer
Allstreamer marked this pull request as draft August 16, 2022 09:04
@Allstreamer
Formatted package_version.rs
091d1ce
- Fixed naming
- `VERSION_VALIDATIOR` to `VERSION_VALIDATOR`
- `ReleaseCanidate` to `ReleaseCandidate`
- Did some manual formatting
- Ran cargo fmt
@Allstreamer
Allstreamer marked this pull request as ready for review August 16, 2022 11:15
@John15321John15321 changed the title [#25] Python versioning System[#25] Python versioning SystemAug 16, 2022
@John15321John15321 changed the title [#25] Python versioning System[#25] Python versioning SystemAug 16, 2022
@Allstreamer
Create CHANGELOG.md
3d1a0ab
- Created base template changelog including dev branch changes
@Allstreamer
Revert "Create CHANGELOG.md"
5d26bd3
This reverts commit 3d1a0ab.
@Allstreamer

Allstreamer commented Aug 23, 2022

Copy link
Copy Markdown
CollaboratorAuthor

So how are we looking on merging this?

@AllstreamerAllstreamer linked an issue Aug 23, 2022 that may be closed by this pull request
Add Python version parsing [PEP-440] #25
Open
@John15321

John15321 commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

So how are we looking on merging this?

I want us to finish the project/CI setup first. So just leave it for now, its not gonna run away :) And focus on other CI/Project related issues

@John15321

John15321 commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

@Allstreamer looks like your package is doing well. Can you change this code to simply use pyver?

@Allstreamer

Allstreamer commented Sep 14, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Will do gimme 30-40 min

@Allstreamer
Add pyver
7d1f368
- Removed Old dependencies
- Add pyver crate
- Update usages
- Removed package_version
@AllstreamerAllstreamer changed the title [#25] Python versioning System[#25] Added PyVer CrateSep 14, 2022
@Allstreamer

Allstreamer commented Sep 14, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Should be good to go! @John15321

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@John15321John15321Awaiting requested review from John15321

At least 1 approving review is required to merge this pull request.

Assignees

@AllstreamerAllstreamer

Labels

documentationImprovements or additions to documentationnew featureNew feature or request

Projects

None yet

Milestone

⬇️ Create basic download/install func...

Development

Successfully merging this pull request may close these issues.

Add Python version parsing [PEP-440]

2 participants

@Allstreamer@John15321