Uh oh!
There was an error while loading. Please reload this page.
Sort errors in error.rs in order - #358
Closed
sladyn98 wants to merge 1 commit into
Closed
Conversation
ksquirrel
commented
Jun 5, 2021
Member
TheSven73
commented
Jun 5, 2021
Collaborator
Thanks for the contribution!! 💯 However I don't think this PR can or should close #309: it does not add the remaining errors. |
sladyn98
commented
Jun 5, 2021
Author
@TheSven73 Yes, I am adding the remaining in a second commit :) |
TheSven73
commented
Jun 5, 2021
Collaborator
That's cool, but why not add both commits to the same PR? Or is that the plan? |
ojeda
commented
Jun 5, 2021
Member
Approved CI to run -- thanks for joining the project! :) |
ojeda
commented
Jun 7, 2021
Member
To clarify: the problem is that the PR closes automatically the issue if you write "Closes #309" :) So either remove that comment (so that the issue is not automatically closed) or add the other commit here. Also please fix the issues that @ksquirrel found. |
kloenk
commented
Aug 22, 2021
Member
maybe also relevant: #455 |
ojeda
commented
Oct 15, 2021
Member
This was done in #436. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorts the errors in
errors.rsaccording toinclude/uapi/asm-generic/errno-base.hCloses#309