Uh oh!
There was an error while loading. Please reload this page.
rust: add support for calling some security functions. - #411
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
wedsonaf
marked this pull request as draft
July 1, 2021 22:03
bjorn3
approved these changes
Jul 2, 2021
bjorn3
commented
Jul 2, 2021
Member
Looks like I was a bit too eager to approve. The rust side changes LGTM, but as the CI shows this still needs the C side to be implemented. |
wedsonaf
commented
Jul 2, 2021
Author
It looks like some architectures don't define the C functions. I'll update this PR to include C helpers. |
This allows drivers to call functions in security modules that take objects for which we have abstractions (e.g., files and tasks) as arguments. Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com>
ksquirrel
commented
Jul 2, 2021
Member
Review of
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows drivers to call functions in security modules that take
objects for which we have abstractions (e.g., files and tasks) as
arguments.
Based on #410.
Signed-off-by: Wedson Almeida Filho wedsonaf@google.com