Skip to content

rust: separate parse and codegen in module! - #423

Open
nbdd0121 wants to merge 1 commit into
Rust-for-Linux:rustfrom
nbdd0121:modules
Open

rust: separate parse and codegen in module!#423
nbdd0121 wants to merge 1 commit into
Rust-for-Linux:rustfrom
nbdd0121:modules

Conversation

@nbdd0121

@nbdd0121nbdd0121 commented Jul 2, 2021

Copy link
Copy Markdown
Member

Doing so allows module_misc_device! to do codegen directly instead of
generating a module! invocation. Generating module! invocation is
error-prone and would require significant effort when features are added
to module! macro or when syntax is changed.

Split from #278

@ksquirrel

This comment has been minimized.

Sign in to view
@ksquirrel

This comment has been minimized.

Sign in to view
@nbdd0121
rust: separate parse and codegen in module!
1bc00dc
Doing so allows `module_misc_device!` to do codegen directly instead of
generating a `module!` invocation. Generating `module!` invocation is
error-prone and would require significant effort when features are added
to `module!` macro or when syntax is changed.
Signed-off-by: Gary Guo <gary@garyguo.net>
@ksquirrel

ksquirrel commented Jul 2, 2021

Copy link
Copy Markdown
Member

Review of 1bc00dca0f30:

@nbdd0121

nbdd0121 commented Jul 2, 2021

Copy link
Copy Markdown
MemberAuthor

transient CI failure again 😅

@phi-gammaphi-gamma mentioned this pull request Sep 5, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nbdd0121@ksquirrel