Skip to content

remove #[disable_initialized_field_access]#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BennoLossin merged 2 commits into from
Mar 14, 2026
Merged

remove #[disable_initialized_field_access]#111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1b0c3c
internal: init: remove `#[disable_initialized_field_access]`
BennoLossin Feb 27, 2026
ef5a2da
internal: init: document load-bearing fact of field accessors
BennoLossin Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `[pin_]init!` now supports attributes on fields (such as `#[cfg(...)]`).
- Add a `#[default_error(<type>)]` attribute to `[pin_]init!` to override the
default error (when no `? Error` is specified).
- Support packed struct in `[pin_]init!` with `#[disable_initialized_field_access]`.

### Removed

Expand Down
47 changes: 16 additions & 31 deletions internal/src/init.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,6 @@ impl InitializerKind {

enum InitializerAttribute {
DefaultError(DefaultErrorAttribute),
DisableInitializedFieldAccess,
}

struct DefaultErrorAttribute {
Expand All@@ -86,6 +85,7 @@ pub(crate) fn expand(
let error = error.map_or_else(
|| {
if let Some(default_error) = attrs.iter().fold(None, |acc, attr| {
#[expect(irrefutable_let_patterns)]
if let InitializerAttribute::DefaultError(DefaultErrorAttribute { ty }) = attr {
Some(ty.clone())
} else {
Expand DownExpand Up@@ -145,15 +145,7 @@ pub(crate) fn expand(
};
// `mixed_site` ensures that the data is not accessible to the user-controlled code.
let data = Ident::new("__data", Span::mixed_site());
let init_fields = init_fields(
&fields,
pinned,
!attrs
.iter()
.any(|attr| matches!(attr, InitializerAttribute::DisableInitializedFieldAccess)),
&data,
&slot,
);
let init_fields = init_fields(&fields, pinned, &data, &slot);
let field_check = make_field_check(&fields, init_kind, &path);
Ok(quote! {{
// We do not want to allow arbitrary returns, so we declare this type as the `Ok` return
Expand DownExpand Up@@ -242,7 +234,6 @@ fn get_init_kind(rest: Option<(Token![..], Expr)>, dcx: &mut DiagCtxt) -> InitKi
fn init_fields(
fields: &Punctuated<InitializerField, Token![,]>,
pinned: bool,
generate_initialized_accessors: bool,
data: &Ident,
slot: &Ident,
) -> TokenStream {
Expand All@@ -266,6 +257,10 @@ fn init_fields(
});
// Again span for better diagnostics
let write = quote_spanned!(ident.span()=> ::core::ptr::write);
// NOTE: the field accessor ensures that the initialized field is properly aligned.
// Unaligned fields will cause the compiler to emit E0793. We do not support
// unaligned fields since `Init::__init` requires an aligned pointer; the call to
// `ptr::write` below has the same requirement.
let accessor = if pinned {
let project_ident = format_ident!("__project_{ident}");
quote! {
Expand All@@ -278,26 +273,25 @@ fn init_fields(
unsafe { &mut (*#slot).#ident }
}
};
let accessor = generate_initialized_accessors.then(|| {
quote! {
#(#cfgs)*
#[allow(unused_variables)]
let #ident = #accessor;
}
});
quote! {
#(#attrs)*
{
#value_prep
// SAFETY: TODO
unsafe { #write(&raw mut (*#slot).#ident, #value_ident) };
}
#accessor
#(#cfgs)*
#[allow(unused_variables)]
let #ident = #accessor;
}
}
InitializerKind::Init { ident, value, .. } => {
// Again span for better diagnostics
let init = format_ident!("init", span = value.span());
// NOTE: the field accessor ensures that the initialized field is properly aligned.
// Unaligned fields will cause the compiler to emit E0793. We do not support
// unaligned fields since `Init::__init` requires an aligned pointer; the call to
// `ptr::write` below has the same requirement.
let (value_init, accessor) = if pinned {
let project_ident = format_ident!("__project_{ident}");
(
Expand DownExpand Up@@ -332,20 +326,15 @@ fn init_fields(
},
)
};
let accessor = generate_initialized_accessors.then(|| {
quote! {
#(#cfgs)*
#[allow(unused_variables)]
let #ident = #accessor;
}
});
quote! {
#(#attrs)*
{
let #init = #value;
#value_init
}
#accessor
#(#cfgs)*
#[allow(unused_variables)]
let #ident = #accessor;
}
}
InitializerKind::Code { block: value, .. } => quote! {
Expand DownExpand Up@@ -472,10 +461,6 @@ impl Parse for Initializer {
if a.path().is_ident("default_error") {
a.parse_args::<DefaultErrorAttribute>()
.map(InitializerAttribute::DefaultError)
} else if a.path().is_ident("disable_initialized_field_access") {
a.meta
.require_path_only()
.map(|_| InitializerAttribute::DisableInitializedFieldAccess)
} else {
Err(syn::Error::new_spanned(a, "unknown initializer attribute"))
}
Expand Down
19 changes: 0 additions & 19 deletions tests/ui/compile-fail/init/no_field_access.rs
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions tests/ui/compile-fail/init/no_field_access.stderr
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions tests/ui/expand/no_field_access.expanded.rs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/ui/expand/no_field_access.rs
View file
Open in desktop

This file was deleted.

, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
remove `#[disable_initialized_field_access]` by BennoLossin · Pull Request #111 · Rust-for-Linux/pin-init · GitHub
Skip to content
remove #[disable_initialized_field_access]#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

BennoLossin
merged 2 commits into

from

Mar 14, 2026
 Merged


remove #[disable_initialized_field_access]#111
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
f1b0c3c

internal: init: remove `#[disable_initialized_field_access]`


BennoLossin Feb 27, 2026
ef5a2da

internal: init: document load-bearing fact of field accessors


BennoLossin Feb 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `[pin_]init!` now supports attributes on fields (such as `#[cfg(...)]`).
- Add a `#[default_error(<type>)]` attribute to `[pin_]init!` to override the
 default error (when no `? Error` is specified).
- Support packed struct in `[pin_]init!` with `#[disable_initialized_field_access]`.

### Removed

Expand Down

47 changes: 16 additions & 31 deletions
internal/src/init.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,6 @@ impl InitializerKind {

enum InitializerAttribute {
 DefaultError(DefaultErrorAttribute),
 DisableInitializedFieldAccess,
}

struct DefaultErrorAttribute {
Expand All@@ -86,6 +85,7 @@ pub(crate) fn expand(
 let error = error.map_or_else(
 || {
 if let Some(default_error) = attrs.iter().fold(None, |acc, attr| {
 #[expect(irrefutable_let_patterns)]
 if let InitializerAttribute::DefaultError(DefaultErrorAttribute { ty }) = attr {
 Some(ty.clone())
 } else {
Expand DownExpand Up@@ -145,15 +145,7 @@ pub(crate) fn expand(
 };
 // `mixed_site` ensures that the data is not accessible to the user-controlled code.
 let data = Ident::new("__data", Span::mixed_site());
 let init_fields = init_fields(
 &fields,
 pinned,
 !attrs
 .iter()
 .any(|attr| matches!(attr, InitializerAttribute::DisableInitializedFieldAccess)),
 &data,
 &slot,
 );
 let init_fields = init_fields(&fields, pinned, &data, &slot);
 let field_check = make_field_check(&fields, init_kind, &path);
 Ok(quote! {{
 // We do not want to allow arbitrary returns, so we declare this type as the `Ok` return
Expand DownExpand Up@@ -242,7 +234,6 @@ fn get_init_kind(rest: Option<(Token![..], Expr)>, dcx: &mut DiagCtxt) -> InitKi
fn init_fields(
 fields: &Punctuated<InitializerField, Token![,]>,
 pinned: bool,
 generate_initialized_accessors: bool,
 data: &Ident,
 slot: &Ident,
) -> TokenStream {
Expand All@@ -266,6 +257,10 @@ fn init_fields(
 });
 // Again span for better diagnostics
 let write = quote_spanned!(ident.span()=> ::core::ptr::write);
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let accessor = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 quote! {
Expand All@@ -278,26 +273,25 @@ fn init_fields(
 unsafe { &mut (*#slot).#ident }
 }
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 #value_prep
 // SAFETY: TODO
 unsafe { #write(&raw mut (*#slot).#ident, #value_ident) };
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Init { ident, value, .. } => {
 // Again span for better diagnostics
 let init = format_ident!("init", span = value.span());
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let (value_init, accessor) = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 (
Expand DownExpand Up@@ -332,20 +326,15 @@ fn init_fields(
 },
 )
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 let #init = #value;
 #value_init
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Code { block: value, .. } => quote! {
Expand DownExpand Up@@ -472,10 +461,6 @@ impl Parse for Initializer {
 if a.path().is_ident("default_error") {
 a.parse_args::<DefaultErrorAttribute>()
 .map(InitializerAttribute::DefaultError)
 } else if a.path().is_ident("disable_initialized_field_access") {
 a.meta
 .require_path_only()
 .map(|_| InitializerAttribute::DisableInitializedFieldAccess)
 } else {
 Err(syn::Error::new_spanned(a, "unknown initializer attribute"))
 }
Expand Down

19 changes: 0 additions & 19 deletions
tests/ui/compile-fail/init/no_field_access.rs

View file


Open in desktop


This file was deleted.


5 changes: 0 additions & 5 deletions
tests/ui/compile-fail/init/no_field_access.stderr

View file


Open in desktop


This file was deleted.


76 changes: 0 additions & 76 deletions
tests/ui/expand/no_field_access.expanded.rs

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
tests/ui/expand/no_field_access.rs

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
remove `#[disable_initialized_field_access]` by BennoLossin · Pull Request #111 · Rust-for-Linux/pin-init · GitHub
Skip to content
remove #[disable_initialized_field_access]#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

BennoLossin
merged 2 commits into

from

Mar 14, 2026
 Merged


remove #[disable_initialized_field_access]#111
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
f1b0c3c

internal: init: remove `#[disable_initialized_field_access]`


BennoLossin Feb 27, 2026
ef5a2da

internal: init: document load-bearing fact of field accessors


BennoLossin Feb 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `[pin_]init!` now supports attributes on fields (such as `#[cfg(...)]`).
- Add a `#[default_error(<type>)]` attribute to `[pin_]init!` to override the
 default error (when no `? Error` is specified).
- Support packed struct in `[pin_]init!` with `#[disable_initialized_field_access]`.

### Removed

Expand Down

47 changes: 16 additions & 31 deletions
internal/src/init.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,6 @@ impl InitializerKind {

enum InitializerAttribute {
 DefaultError(DefaultErrorAttribute),
 DisableInitializedFieldAccess,
}

struct DefaultErrorAttribute {
Expand All@@ -86,6 +85,7 @@ pub(crate) fn expand(
 let error = error.map_or_else(
 || {
 if let Some(default_error) = attrs.iter().fold(None, |acc, attr| {
 #[expect(irrefutable_let_patterns)]
 if let InitializerAttribute::DefaultError(DefaultErrorAttribute { ty }) = attr {
 Some(ty.clone())
 } else {
Expand DownExpand Up@@ -145,15 +145,7 @@ pub(crate) fn expand(
 };
 // `mixed_site` ensures that the data is not accessible to the user-controlled code.
 let data = Ident::new("__data", Span::mixed_site());
 let init_fields = init_fields(
 &fields,
 pinned,
 !attrs
 .iter()
 .any(|attr| matches!(attr, InitializerAttribute::DisableInitializedFieldAccess)),
 &data,
 &slot,
 );
 let init_fields = init_fields(&fields, pinned, &data, &slot);
 let field_check = make_field_check(&fields, init_kind, &path);
 Ok(quote! {{
 // We do not want to allow arbitrary returns, so we declare this type as the `Ok` return
Expand DownExpand Up@@ -242,7 +234,6 @@ fn get_init_kind(rest: Option<(Token![..], Expr)>, dcx: &mut DiagCtxt) -> InitKi
fn init_fields(
 fields: &Punctuated<InitializerField, Token![,]>,
 pinned: bool,
 generate_initialized_accessors: bool,
 data: &Ident,
 slot: &Ident,
) -> TokenStream {
Expand All@@ -266,6 +257,10 @@ fn init_fields(
 });
 // Again span for better diagnostics
 let write = quote_spanned!(ident.span()=> ::core::ptr::write);
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let accessor = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 quote! {
Expand All@@ -278,26 +273,25 @@ fn init_fields(
 unsafe { &mut (*#slot).#ident }
 }
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 #value_prep
 // SAFETY: TODO
 unsafe { #write(&raw mut (*#slot).#ident, #value_ident) };
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Init { ident, value, .. } => {
 // Again span for better diagnostics
 let init = format_ident!("init", span = value.span());
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let (value_init, accessor) = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 (
Expand DownExpand Up@@ -332,20 +326,15 @@ fn init_fields(
 },
 )
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 let #init = #value;
 #value_init
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Code { block: value, .. } => quote! {
Expand DownExpand Up@@ -472,10 +461,6 @@ impl Parse for Initializer {
 if a.path().is_ident("default_error") {
 a.parse_args::<DefaultErrorAttribute>()
 .map(InitializerAttribute::DefaultError)
 } else if a.path().is_ident("disable_initialized_field_access") {
 a.meta
 .require_path_only()
 .map(|_| InitializerAttribute::DisableInitializedFieldAccess)
 } else {
 Err(syn::Error::new_spanned(a, "unknown initializer attribute"))
 }
Expand Down

19 changes: 0 additions & 19 deletions
tests/ui/compile-fail/init/no_field_access.rs

View file


Open in desktop


This file was deleted.


5 changes: 0 additions & 5 deletions
tests/ui/compile-fail/init/no_field_access.stderr

View file


Open in desktop


This file was deleted.


76 changes: 0 additions & 76 deletions
tests/ui/expand/no_field_access.expanded.rs

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
tests/ui/expand/no_field_access.rs

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
remove `#[disable_initialized_field_access]` by BennoLossin · Pull Request #111 · Rust-for-Linux/pin-init · GitHub
Skip to content
remove #[disable_initialized_field_access]#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

BennoLossin
merged 2 commits into

from

Mar 14, 2026
 Merged


remove #[disable_initialized_field_access]#111
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
f1b0c3c

internal: init: remove `#[disable_initialized_field_access]`


BennoLossin Feb 27, 2026
ef5a2da

internal: init: document load-bearing fact of field accessors


BennoLossin Feb 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `[pin_]init!` now supports attributes on fields (such as `#[cfg(...)]`).
- Add a `#[default_error(<type>)]` attribute to `[pin_]init!` to override the
 default error (when no `? Error` is specified).
- Support packed struct in `[pin_]init!` with `#[disable_initialized_field_access]`.

### Removed

Expand Down

47 changes: 16 additions & 31 deletions
internal/src/init.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,6 @@ impl InitializerKind {

enum InitializerAttribute {
 DefaultError(DefaultErrorAttribute),
 DisableInitializedFieldAccess,
}

struct DefaultErrorAttribute {
Expand All@@ -86,6 +85,7 @@ pub(crate) fn expand(
 let error = error.map_or_else(
 || {
 if let Some(default_error) = attrs.iter().fold(None, |acc, attr| {
 #[expect(irrefutable_let_patterns)]
 if let InitializerAttribute::DefaultError(DefaultErrorAttribute { ty }) = attr {
 Some(ty.clone())
 } else {
Expand DownExpand Up@@ -145,15 +145,7 @@ pub(crate) fn expand(
 };
 // `mixed_site` ensures that the data is not accessible to the user-controlled code.
 let data = Ident::new("__data", Span::mixed_site());
 let init_fields = init_fields(
 &fields,
 pinned,
 !attrs
 .iter()
 .any(|attr| matches!(attr, InitializerAttribute::DisableInitializedFieldAccess)),
 &data,
 &slot,
 );
 let init_fields = init_fields(&fields, pinned, &data, &slot);
 let field_check = make_field_check(&fields, init_kind, &path);
 Ok(quote! {{
 // We do not want to allow arbitrary returns, so we declare this type as the `Ok` return
Expand DownExpand Up@@ -242,7 +234,6 @@ fn get_init_kind(rest: Option<(Token![..], Expr)>, dcx: &mut DiagCtxt) -> InitKi
fn init_fields(
 fields: &Punctuated<InitializerField, Token![,]>,
 pinned: bool,
 generate_initialized_accessors: bool,
 data: &Ident,
 slot: &Ident,
) -> TokenStream {
Expand All@@ -266,6 +257,10 @@ fn init_fields(
 });
 // Again span for better diagnostics
 let write = quote_spanned!(ident.span()=> ::core::ptr::write);
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let accessor = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 quote! {
Expand All@@ -278,26 +273,25 @@ fn init_fields(
 unsafe { &mut (*#slot).#ident }
 }
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 #value_prep
 // SAFETY: TODO
 unsafe { #write(&raw mut (*#slot).#ident, #value_ident) };
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Init { ident, value, .. } => {
 // Again span for better diagnostics
 let init = format_ident!("init", span = value.span());
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let (value_init, accessor) = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 (
Expand DownExpand Up@@ -332,20 +326,15 @@ fn init_fields(
 },
 )
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 let #init = #value;
 #value_init
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Code { block: value, .. } => quote! {
Expand DownExpand Up@@ -472,10 +461,6 @@ impl Parse for Initializer {
 if a.path().is_ident("default_error") {
 a.parse_args::<DefaultErrorAttribute>()
 .map(InitializerAttribute::DefaultError)
 } else if a.path().is_ident("disable_initialized_field_access") {
 a.meta
 .require_path_only()
 .map(|_| InitializerAttribute::DisableInitializedFieldAccess)
 } else {
 Err(syn::Error::new_spanned(a, "unknown initializer attribute"))
 }
Expand Down

19 changes: 0 additions & 19 deletions
tests/ui/compile-fail/init/no_field_access.rs

View file


Open in desktop


This file was deleted.


5 changes: 0 additions & 5 deletions
tests/ui/compile-fail/init/no_field_access.stderr

View file


Open in desktop


This file was deleted.


76 changes: 0 additions & 76 deletions
tests/ui/expand/no_field_access.expanded.rs

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
tests/ui/expand/no_field_access.rs

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
remove `#[disable_initialized_field_access]` by BennoLossin · Pull Request #111 · Rust-for-Linux/pin-init · GitHub
Skip to content
remove #[disable_initialized_field_access]#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

BennoLossin
merged 2 commits into

from

Mar 14, 2026
 Merged


remove #[disable_initialized_field_access]#111
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
f1b0c3c

internal: init: remove `#[disable_initialized_field_access]`


BennoLossin Feb 27, 2026
ef5a2da

internal: init: document load-bearing fact of field accessors


BennoLossin Feb 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `[pin_]init!` now supports attributes on fields (such as `#[cfg(...)]`).
- Add a `#[default_error(<type>)]` attribute to `[pin_]init!` to override the
 default error (when no `? Error` is specified).
- Support packed struct in `[pin_]init!` with `#[disable_initialized_field_access]`.

### Removed

Expand Down

47 changes: 16 additions & 31 deletions
internal/src/init.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,6 @@ impl InitializerKind {

enum InitializerAttribute {
 DefaultError(DefaultErrorAttribute),
 DisableInitializedFieldAccess,
}

struct DefaultErrorAttribute {
Expand All@@ -86,6 +85,7 @@ pub(crate) fn expand(
 let error = error.map_or_else(
 || {
 if let Some(default_error) = attrs.iter().fold(None, |acc, attr| {
 #[expect(irrefutable_let_patterns)]
 if let InitializerAttribute::DefaultError(DefaultErrorAttribute { ty }) = attr {
 Some(ty.clone())
 } else {
Expand DownExpand Up@@ -145,15 +145,7 @@ pub(crate) fn expand(
 };
 // `mixed_site` ensures that the data is not accessible to the user-controlled code.
 let data = Ident::new("__data", Span::mixed_site());
 let init_fields = init_fields(
 &fields,
 pinned,
 !attrs
 .iter()
 .any(|attr| matches!(attr, InitializerAttribute::DisableInitializedFieldAccess)),
 &data,
 &slot,
 );
 let init_fields = init_fields(&fields, pinned, &data, &slot);
 let field_check = make_field_check(&fields, init_kind, &path);
 Ok(quote! {{
 // We do not want to allow arbitrary returns, so we declare this type as the `Ok` return
Expand DownExpand Up@@ -242,7 +234,6 @@ fn get_init_kind(rest: Option<(Token![..], Expr)>, dcx: &mut DiagCtxt) -> InitKi
fn init_fields(
 fields: &Punctuated<InitializerField, Token![,]>,
 pinned: bool,
 generate_initialized_accessors: bool,
 data: &Ident,
 slot: &Ident,
) -> TokenStream {
Expand All@@ -266,6 +257,10 @@ fn init_fields(
 });
 // Again span for better diagnostics
 let write = quote_spanned!(ident.span()=> ::core::ptr::write);
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let accessor = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 quote! {
Expand All@@ -278,26 +273,25 @@ fn init_fields(
 unsafe { &mut (*#slot).#ident }
 }
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 #value_prep
 // SAFETY: TODO
 unsafe { #write(&raw mut (*#slot).#ident, #value_ident) };
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Init { ident, value, .. } => {
 // Again span for better diagnostics
 let init = format_ident!("init", span = value.span());
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let (value_init, accessor) = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 (
Expand DownExpand Up@@ -332,20 +326,15 @@ fn init_fields(
 },
 )
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 let #init = #value;
 #value_init
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Code { block: value, .. } => quote! {
Expand DownExpand Up@@ -472,10 +461,6 @@ impl Parse for Initializer {
 if a.path().is_ident("default_error") {
 a.parse_args::<DefaultErrorAttribute>()
 .map(InitializerAttribute::DefaultError)
 } else if a.path().is_ident("disable_initialized_field_access") {
 a.meta
 .require_path_only()
 .map(|_| InitializerAttribute::DisableInitializedFieldAccess)
 } else {
 Err(syn::Error::new_spanned(a, "unknown initializer attribute"))
 }
Expand Down

19 changes: 0 additions & 19 deletions
tests/ui/compile-fail/init/no_field_access.rs

View file


Open in desktop


This file was deleted.


5 changes: 0 additions & 5 deletions
tests/ui/compile-fail/init/no_field_access.stderr

View file


Open in desktop


This file was deleted.


76 changes: 0 additions & 76 deletions
tests/ui/expand/no_field_access.expanded.rs

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
tests/ui/expand/no_field_access.rs

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
remove `#[disable_initialized_field_access]` by BennoLossin · Pull Request #111 · Rust-for-Linux/pin-init · GitHub
Skip to content
remove #[disable_initialized_field_access]#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

BennoLossin
merged 2 commits into

from

Mar 14, 2026
 Merged


remove #[disable_initialized_field_access]#111
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
f1b0c3c

internal: init: remove `#[disable_initialized_field_access]`


BennoLossin Feb 27, 2026
ef5a2da

internal: init: document load-bearing fact of field accessors


BennoLossin Feb 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `[pin_]init!` now supports attributes on fields (such as `#[cfg(...)]`).
- Add a `#[default_error(<type>)]` attribute to `[pin_]init!` to override the
 default error (when no `? Error` is specified).
- Support packed struct in `[pin_]init!` with `#[disable_initialized_field_access]`.

### Removed

Expand Down

47 changes: 16 additions & 31 deletions
internal/src/init.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,6 @@ impl InitializerKind {

enum InitializerAttribute {
 DefaultError(DefaultErrorAttribute),
 DisableInitializedFieldAccess,
}

struct DefaultErrorAttribute {
Expand All@@ -86,6 +85,7 @@ pub(crate) fn expand(
 let error = error.map_or_else(
 || {
 if let Some(default_error) = attrs.iter().fold(None, |acc, attr| {
 #[expect(irrefutable_let_patterns)]
 if let InitializerAttribute::DefaultError(DefaultErrorAttribute { ty }) = attr {
 Some(ty.clone())
 } else {
Expand DownExpand Up@@ -145,15 +145,7 @@ pub(crate) fn expand(
 };
 // `mixed_site` ensures that the data is not accessible to the user-controlled code.
 let data = Ident::new("__data", Span::mixed_site());
 let init_fields = init_fields(
 &fields,
 pinned,
 !attrs
 .iter()
 .any(|attr| matches!(attr, InitializerAttribute::DisableInitializedFieldAccess)),
 &data,
 &slot,
 );
 let init_fields = init_fields(&fields, pinned, &data, &slot);
 let field_check = make_field_check(&fields, init_kind, &path);
 Ok(quote! {{
 // We do not want to allow arbitrary returns, so we declare this type as the `Ok` return
Expand DownExpand Up@@ -242,7 +234,6 @@ fn get_init_kind(rest: Option<(Token![..], Expr)>, dcx: &mut DiagCtxt) -> InitKi
fn init_fields(
 fields: &Punctuated<InitializerField, Token![,]>,
 pinned: bool,
 generate_initialized_accessors: bool,
 data: &Ident,
 slot: &Ident,
) -> TokenStream {
Expand All@@ -266,6 +257,10 @@ fn init_fields(
 });
 // Again span for better diagnostics
 let write = quote_spanned!(ident.span()=> ::core::ptr::write);
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let accessor = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 quote! {
Expand All@@ -278,26 +273,25 @@ fn init_fields(
 unsafe { &mut (*#slot).#ident }
 }
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 #value_prep
 // SAFETY: TODO
 unsafe { #write(&raw mut (*#slot).#ident, #value_ident) };
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Init { ident, value, .. } => {
 // Again span for better diagnostics
 let init = format_ident!("init", span = value.span());
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let (value_init, accessor) = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 (
Expand DownExpand Up@@ -332,20 +326,15 @@ fn init_fields(
 },
 )
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 let #init = #value;
 #value_init
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Code { block: value, .. } => quote! {
Expand DownExpand Up@@ -472,10 +461,6 @@ impl Parse for Initializer {
 if a.path().is_ident("default_error") {
 a.parse_args::<DefaultErrorAttribute>()
 .map(InitializerAttribute::DefaultError)
 } else if a.path().is_ident("disable_initialized_field_access") {
 a.meta
 .require_path_only()
 .map(|_| InitializerAttribute::DisableInitializedFieldAccess)
 } else {
 Err(syn::Error::new_spanned(a, "unknown initializer attribute"))
 }
Expand Down

19 changes: 0 additions & 19 deletions
tests/ui/compile-fail/init/no_field_access.rs

View file


Open in desktop


This file was deleted.


5 changes: 0 additions & 5 deletions
tests/ui/compile-fail/init/no_field_access.stderr

View file


Open in desktop


This file was deleted.


76 changes: 0 additions & 76 deletions
tests/ui/expand/no_field_access.expanded.rs

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
tests/ui/expand/no_field_access.rs

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
remove `#[disable_initialized_field_access]` by BennoLossin · Pull Request #111 · Rust-for-Linux/pin-init · GitHub
Skip to content
remove #[disable_initialized_field_access]#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

BennoLossin
merged 2 commits into

from

Mar 14, 2026
 Merged


remove #[disable_initialized_field_access]#111
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
f1b0c3c

internal: init: remove `#[disable_initialized_field_access]`


BennoLossin Feb 27, 2026
ef5a2da

internal: init: document load-bearing fact of field accessors


BennoLossin Feb 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `[pin_]init!` now supports attributes on fields (such as `#[cfg(...)]`).
- Add a `#[default_error(<type>)]` attribute to `[pin_]init!` to override the
 default error (when no `? Error` is specified).
- Support packed struct in `[pin_]init!` with `#[disable_initialized_field_access]`.

### Removed

Expand Down

47 changes: 16 additions & 31 deletions
internal/src/init.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,6 @@ impl InitializerKind {

enum InitializerAttribute {
 DefaultError(DefaultErrorAttribute),
 DisableInitializedFieldAccess,
}

struct DefaultErrorAttribute {
Expand All@@ -86,6 +85,7 @@ pub(crate) fn expand(
 let error = error.map_or_else(
 || {
 if let Some(default_error) = attrs.iter().fold(None, |acc, attr| {
 #[expect(irrefutable_let_patterns)]
 if let InitializerAttribute::DefaultError(DefaultErrorAttribute { ty }) = attr {
 Some(ty.clone())
 } else {
Expand DownExpand Up@@ -145,15 +145,7 @@ pub(crate) fn expand(
 };
 // `mixed_site` ensures that the data is not accessible to the user-controlled code.
 let data = Ident::new("__data", Span::mixed_site());
 let init_fields = init_fields(
 &fields,
 pinned,
 !attrs
 .iter()
 .any(|attr| matches!(attr, InitializerAttribute::DisableInitializedFieldAccess)),
 &data,
 &slot,
 );
 let init_fields = init_fields(&fields, pinned, &data, &slot);
 let field_check = make_field_check(&fields, init_kind, &path);
 Ok(quote! {{
 // We do not want to allow arbitrary returns, so we declare this type as the `Ok` return
Expand DownExpand Up@@ -242,7 +234,6 @@ fn get_init_kind(rest: Option<(Token![..], Expr)>, dcx: &mut DiagCtxt) -> InitKi
fn init_fields(
 fields: &Punctuated<InitializerField, Token![,]>,
 pinned: bool,
 generate_initialized_accessors: bool,
 data: &Ident,
 slot: &Ident,
) -> TokenStream {
Expand All@@ -266,6 +257,10 @@ fn init_fields(
 });
 // Again span for better diagnostics
 let write = quote_spanned!(ident.span()=> ::core::ptr::write);
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let accessor = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 quote! {
Expand All@@ -278,26 +273,25 @@ fn init_fields(
 unsafe { &mut (*#slot).#ident }
 }
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 #value_prep
 // SAFETY: TODO
 unsafe { #write(&raw mut (*#slot).#ident, #value_ident) };
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Init { ident, value, .. } => {
 // Again span for better diagnostics
 let init = format_ident!("init", span = value.span());
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let (value_init, accessor) = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 (
Expand DownExpand Up@@ -332,20 +326,15 @@ fn init_fields(
 },
 )
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 let #init = #value;
 #value_init
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Code { block: value, .. } => quote! {
Expand DownExpand Up@@ -472,10 +461,6 @@ impl Parse for Initializer {
 if a.path().is_ident("default_error") {
 a.parse_args::<DefaultErrorAttribute>()
 .map(InitializerAttribute::DefaultError)
 } else if a.path().is_ident("disable_initialized_field_access") {
 a.meta
 .require_path_only()
 .map(|_| InitializerAttribute::DisableInitializedFieldAccess)
 } else {
 Err(syn::Error::new_spanned(a, "unknown initializer attribute"))
 }
Expand Down

19 changes: 0 additions & 19 deletions
tests/ui/compile-fail/init/no_field_access.rs

View file


Open in desktop


This file was deleted.


5 changes: 0 additions & 5 deletions
tests/ui/compile-fail/init/no_field_access.stderr

View file


Open in desktop


This file was deleted.


76 changes: 0 additions & 76 deletions
tests/ui/expand/no_field_access.expanded.rs

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
tests/ui/expand/no_field_access.rs

View file


Open in desktop


This file was deleted.


, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
remove `#[disable_initialized_field_access]` by BennoLossin · Pull Request #111 · Rust-for-Linux/pin-init · GitHub
Skip to content
remove #[disable_initialized_field_access]#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

BennoLossin
merged 2 commits into

from

Mar 14, 2026
 Merged


remove #[disable_initialized_field_access]#111
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
f1b0c3c

internal: init: remove `#[disable_initialized_field_access]`


BennoLossin Feb 27, 2026
ef5a2da

internal: init: document load-bearing fact of field accessors


BennoLossin Feb 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `[pin_]init!` now supports attributes on fields (such as `#[cfg(...)]`).
- Add a `#[default_error(<type>)]` attribute to `[pin_]init!` to override the
 default error (when no `? Error` is specified).
- Support packed struct in `[pin_]init!` with `#[disable_initialized_field_access]`.

### Removed

Expand Down

47 changes: 16 additions & 31 deletions
internal/src/init.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,6 @@ impl InitializerKind {

enum InitializerAttribute {
 DefaultError(DefaultErrorAttribute),
 DisableInitializedFieldAccess,
}

struct DefaultErrorAttribute {
Expand All@@ -86,6 +85,7 @@ pub(crate) fn expand(
 let error = error.map_or_else(
 || {
 if let Some(default_error) = attrs.iter().fold(None, |acc, attr| {
 #[expect(irrefutable_let_patterns)]
 if let InitializerAttribute::DefaultError(DefaultErrorAttribute { ty }) = attr {
 Some(ty.clone())
 } else {
Expand DownExpand Up@@ -145,15 +145,7 @@ pub(crate) fn expand(
 };
 // `mixed_site` ensures that the data is not accessible to the user-controlled code.
 let data = Ident::new("__data", Span::mixed_site());
 let init_fields = init_fields(
 &fields,
 pinned,
 !attrs
 .iter()
 .any(|attr| matches!(attr, InitializerAttribute::DisableInitializedFieldAccess)),
 &data,
 &slot,
 );
 let init_fields = init_fields(&fields, pinned, &data, &slot);
 let field_check = make_field_check(&fields, init_kind, &path);
 Ok(quote! {{
 // We do not want to allow arbitrary returns, so we declare this type as the `Ok` return
Expand DownExpand Up@@ -242,7 +234,6 @@ fn get_init_kind(rest: Option<(Token![..], Expr)>, dcx: &mut DiagCtxt) -> InitKi
fn init_fields(
 fields: &Punctuated<InitializerField, Token![,]>,
 pinned: bool,
 generate_initialized_accessors: bool,
 data: &Ident,
 slot: &Ident,
) -> TokenStream {
Expand All@@ -266,6 +257,10 @@ fn init_fields(
 });
 // Again span for better diagnostics
 let write = quote_spanned!(ident.span()=> ::core::ptr::write);
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let accessor = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 quote! {
Expand All@@ -278,26 +273,25 @@ fn init_fields(
 unsafe { &mut (*#slot).#ident }
 }
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 #value_prep
 // SAFETY: TODO
 unsafe { #write(&raw mut (*#slot).#ident, #value_ident) };
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Init { ident, value, .. } => {
 // Again span for better diagnostics
 let init = format_ident!("init", span = value.span());
 // NOTE: the field accessor ensures that the initialized field is properly aligned.
 // Unaligned fields will cause the compiler to emit E0793. We do not support
 // unaligned fields since `Init::__init` requires an aligned pointer; the call to
 // `ptr::write` below has the same requirement.
 let (value_init, accessor) = if pinned {
 let project_ident = format_ident!("__project_{ident}");
 (
Expand DownExpand Up@@ -332,20 +326,15 @@ fn init_fields(
 },
 )
 };
 let accessor = generate_initialized_accessors.then(|| {
 quote! {
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 });
 quote! {
 #(#attrs)*
 {
 let #init = #value;
 #value_init
 }
 #accessor
 #(#cfgs)*
 #[allow(unused_variables)]
 let #ident = #accessor;
 }
 }
 InitializerKind::Code { block: value, .. } => quote! {
Expand DownExpand Up@@ -472,10 +461,6 @@ impl Parse for Initializer {
 if a.path().is_ident("default_error") {
 a.parse_args::<DefaultErrorAttribute>()
 .map(InitializerAttribute::DefaultError)
 } else if a.path().is_ident("disable_initialized_field_access") {
 a.meta
 .require_path_only()
 .map(|_| InitializerAttribute::DisableInitializedFieldAccess)
 } else {
 Err(syn::Error::new_spanned(a, "unknown initializer attribute"))
 }
Expand Down

19 changes: 0 additions & 19 deletions
tests/ui/compile-fail/init/no_field_access.rs

View file


Open in desktop


This file was deleted.


5 changes: 0 additions & 5 deletions
tests/ui/compile-fail/init/no_field_access.stderr

View file


Open in desktop


This file was deleted.


76 changes: 0 additions & 76 deletions
tests/ui/expand/no_field_access.expanded.rs

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
tests/ui/expand/no_field_access.rs

View file


Open in desktop


This file was deleted.