Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 119
Implement macOS cursor setting and hiding support#280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -3,7 +3,7 @@ use std::rc::Rc; | ||
| use objc2::rc::{autoreleasepool, Weak}; | ||
| use objc2::runtime::NSObjectProtocol; | ||
| use objc2::MainThreadMarker; | ||
| use objc2::{ClassType, MainThreadMarker}; | ||
| use objc2_app_kit::{ | ||
| NSApplication, NSApplicationActivationPolicy, NSPasteboard, NSPasteboardTypeString, | ||
| }; | ||
| @@ -156,7 +156,21 @@ impl<'a> Window<'a> { | ||
| pub fn set_mouse_cursor(&self, cursor: MouseCursor) { | ||
| let native_cursor = Cursor::from(cursor); | ||
| self.view.addCursorRect_cursor(self.view.bounds(), &native_cursor.load()); | ||
| unsafe { | ||
| if let Some(loaded_cursor) = native_cursor.load() { | ||
| if self.inner.state.cursor_hidden.get() { | ||
| let _: () = objc2::msg_send![objc2_app_kit::NSCursor::class(), unhide]; | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, this should use the safe APIs instead of msg_send here | ||
| self.inner.state.cursor_hidden.set(false); | ||
| } | ||
| let _: () = objc2::msg_send![&loaded_cursor, set]; | ||
| self.view.addCursorRect_cursor(self.view.bounds(), &loaded_cursor); | ||
| } else { | ||
| if !self.inner.state.cursor_hidden.get() { | ||
| let _: () = objc2::msg_send![objc2_app_kit::NSCursor::class(), hide]; | ||
| self.inner.state.cursor_hidden.set(true); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| #[cfg(feature = "opengl")] | ||
| @@ -169,13 +183,15 @@ pub(crate) struct WindowSharedState { | ||
| /// The last known window info for this window. | ||
| pub window_info: Cell<WindowInfo>, | ||
| pub closed: Cell<bool>, | ||
| pub cursor_hidden: Cell<bool>, | ||
| } | ||
| impl WindowSharedState { | ||
| pub fn new(options: &WindowOpenOptions) -> Self { | ||
| Self { | ||
| window_info: WindowInfo::from_logical_size(options.size, 1.0).into(), | ||
| closed: false.into(), | ||
| cursor_hidden: false.into(), | ||
| } | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use NSCursor::unhide directly, instead of using a raw, unsafe msg_send call