eax: Allow variable tag length by Flakebi · Pull Request #231 · RustCrypto/AEADs

Flakebi · 2020-10-17T17:42:11Z

Implemented analogous to ccm by passing a second generic argument to
Eax.

Fixes#220.

This change should be mostly backwards compatible, apart from exporting the generic Tag instead of pub type Tag = GenericArray<u8, U16>;
It should be easy to make keep it completely backwards compatible if that’s better.

codecov-io · 2020-10-17T17:44:07Z

Codecov Report

Merging #231 into master will decrease coverage by 0.17%.
The diff coverage is 29.41%.

@@ Coverage Diff @@## master #231 +/- ##
==========================================
- Coverage 83.40% 83.22% -0.18% 
==========================================
Files 31 31 Lines 1115 1121 +6 ==========================================
+ Hits 930 933 +3 - Misses 185 188 +3

Impacted Files	Coverage Δ
eax/src/online.rs	`0.00% <0.00%> (ø)`
eax/src/lib.rs	`90.90% <100.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4d072...8874ea1. Read the comment docs.

newpavlov

As a temporary solution it looks good to me, but in future I would prefer to have the "hazmat" methods discussed in the parent issue.

newpavlov · 2020-10-18T11:26:33Z

+
+impl TagSize for U1 {}
+impl TagSize for U2 {}
+impl TagSize for U3 {}


Are we sure we want to allow such short tags? Also I think it should be possible to specify a range bound using typenum without introducing the sealed trait (see typenum::type_operators), though the current approach is simple and easier to understand, so we can leave it as-is.

Implemented analogous to ccm by passing a second generic argument to Eax.

Flakebi · 2020-10-18T13:02:26Z

I changed the TagSize to be >= U4 and <= U16 and also put back the original eax::Tag alias, so the change should be backwards compatible.

tarcieri · 2020-10-18T14:52:22Z

@Flakebi LGTM, and matches the ccm crate

Flakebi · 2020-10-17T17:42:11Z

Implemented analogous to ccm by passing a second generic argument to
Eax.

Fixes#220.

This change should be mostly backwards compatible, apart from exporting the generic Tag instead of pub type Tag = GenericArray<u8, U16>;
It should be easy to make keep it completely backwards compatible if that’s better.

codecov-io · 2020-10-17T17:44:07Z

Codecov Report

Merging #231 into master will decrease coverage by 0.17%.
The diff coverage is 29.41%.

@@ Coverage Diff @@## master #231 +/- ##
==========================================
- Coverage 83.40% 83.22% -0.18% 
==========================================
Files 31 31 Lines 1115 1121 +6 ==========================================
+ Hits 930 933 +3 - Misses 185 188 +3

Impacted Files	Coverage Δ
eax/src/online.rs	`0.00% <0.00%> (ø)`
eax/src/lib.rs	`90.90% <100.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4d072...8874ea1. Read the comment docs.

newpavlov

As a temporary solution it looks good to me, but in future I would prefer to have the "hazmat" methods discussed in the parent issue.

newpavlov · 2020-10-18T11:26:33Z

+
+impl TagSize for U1 {}
+impl TagSize for U2 {}
+impl TagSize for U3 {}


Are we sure we want to allow such short tags? Also I think it should be possible to specify a range bound using typenum without introducing the sealed trait (see typenum::type_operators), though the current approach is simple and easier to understand, so we can leave it as-is.

Implemented analogous to ccm by passing a second generic argument to Eax.

Flakebi · 2020-10-18T13:02:26Z

I changed the TagSize to be >= U4 and <= U16 and also put back the original eax::Tag alias, so the change should be backwards compatible.

tarcieri · 2020-10-18T14:52:22Z

@Flakebi LGTM, and matches the ccm crate

Flakebi · 2020-10-17T17:42:11Z

Implemented analogous to ccm by passing a second generic argument to
Eax.

Fixes#220.

This change should be mostly backwards compatible, apart from exporting the generic Tag instead of pub type Tag = GenericArray<u8, U16>;
It should be easy to make keep it completely backwards compatible if that’s better.

codecov-io · 2020-10-17T17:44:07Z

Codecov Report

Merging #231 into master will decrease coverage by 0.17%.
The diff coverage is 29.41%.

@@ Coverage Diff @@## master #231 +/- ##
==========================================
- Coverage 83.40% 83.22% -0.18% 
==========================================
Files 31 31 Lines 1115 1121 +6 ==========================================
+ Hits 930 933 +3 - Misses 185 188 +3

Impacted Files	Coverage Δ
eax/src/online.rs	`0.00% <0.00%> (ø)`
eax/src/lib.rs	`90.90% <100.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4d072...8874ea1. Read the comment docs.

newpavlov

As a temporary solution it looks good to me, but in future I would prefer to have the "hazmat" methods discussed in the parent issue.

newpavlov · 2020-10-18T11:26:33Z

+
+impl TagSize for U1 {}
+impl TagSize for U2 {}
+impl TagSize for U3 {}


Are we sure we want to allow such short tags? Also I think it should be possible to specify a range bound using typenum without introducing the sealed trait (see typenum::type_operators), though the current approach is simple and easier to understand, so we can leave it as-is.

Implemented analogous to ccm by passing a second generic argument to Eax.

Flakebi · 2020-10-18T13:02:26Z

I changed the TagSize to be >= U4 and <= U16 and also put back the original eax::Tag alias, so the change should be backwards compatible.

tarcieri · 2020-10-18T14:52:22Z

@Flakebi LGTM, and matches the ccm crate

Flakebi · 2020-10-17T17:42:11Z

Implemented analogous to ccm by passing a second generic argument to
Eax.

Fixes#220.

This change should be mostly backwards compatible, apart from exporting the generic Tag instead of pub type Tag = GenericArray<u8, U16>;
It should be easy to make keep it completely backwards compatible if that’s better.

codecov-io · 2020-10-17T17:44:07Z

Codecov Report

Merging #231 into master will decrease coverage by 0.17%.
The diff coverage is 29.41%.

@@ Coverage Diff @@## master #231 +/- ##
==========================================
- Coverage 83.40% 83.22% -0.18% 
==========================================
Files 31 31 Lines 1115 1121 +6 ==========================================
+ Hits 930 933 +3 - Misses 185 188 +3

Impacted Files	Coverage Δ
eax/src/online.rs	`0.00% <0.00%> (ø)`
eax/src/lib.rs	`90.90% <100.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4d072...8874ea1. Read the comment docs.

newpavlov

As a temporary solution it looks good to me, but in future I would prefer to have the "hazmat" methods discussed in the parent issue.

newpavlov · 2020-10-18T11:26:33Z

+
+impl TagSize for U1 {}
+impl TagSize for U2 {}
+impl TagSize for U3 {}


Are we sure we want to allow such short tags? Also I think it should be possible to specify a range bound using typenum without introducing the sealed trait (see typenum::type_operators), though the current approach is simple and easier to understand, so we can leave it as-is.

Implemented analogous to ccm by passing a second generic argument to Eax.

Flakebi · 2020-10-18T13:02:26Z

I changed the TagSize to be >= U4 and <= U16 and also put back the original eax::Tag alias, so the change should be backwards compatible.

tarcieri · 2020-10-18T14:52:22Z

@Flakebi LGTM, and matches the ccm crate

Flakebi · 2020-10-17T17:42:11Z

Implemented analogous to ccm by passing a second generic argument to
Eax.

Fixes#220.

This change should be mostly backwards compatible, apart from exporting the generic Tag instead of pub type Tag = GenericArray<u8, U16>;
It should be easy to make keep it completely backwards compatible if that’s better.

codecov-io · 2020-10-17T17:44:07Z

Codecov Report

Merging #231 into master will decrease coverage by 0.17%.
The diff coverage is 29.41%.

@@ Coverage Diff @@## master #231 +/- ##
==========================================
- Coverage 83.40% 83.22% -0.18% 
==========================================
Files 31 31 Lines 1115 1121 +6 ==========================================
+ Hits 930 933 +3 - Misses 185 188 +3

Impacted Files	Coverage Δ
eax/src/online.rs	`0.00% <0.00%> (ø)`
eax/src/lib.rs	`90.90% <100.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4d072...8874ea1. Read the comment docs.

newpavlov

As a temporary solution it looks good to me, but in future I would prefer to have the "hazmat" methods discussed in the parent issue.

newpavlov · 2020-10-18T11:26:33Z

+
+impl TagSize for U1 {}
+impl TagSize for U2 {}
+impl TagSize for U3 {}


Are we sure we want to allow such short tags? Also I think it should be possible to specify a range bound using typenum without introducing the sealed trait (see typenum::type_operators), though the current approach is simple and easier to understand, so we can leave it as-is.

Implemented analogous to ccm by passing a second generic argument to Eax.

Flakebi · 2020-10-18T13:02:26Z

I changed the TagSize to be >= U4 and <= U16 and also put back the original eax::Tag alias, so the change should be backwards compatible.

tarcieri · 2020-10-18T14:52:22Z

@Flakebi LGTM, and matches the ccm crate

Flakebi · 2020-10-17T17:42:11Z

Implemented analogous to ccm by passing a second generic argument to
Eax.

Fixes#220.

This change should be mostly backwards compatible, apart from exporting the generic Tag instead of pub type Tag = GenericArray<u8, U16>;
It should be easy to make keep it completely backwards compatible if that’s better.

codecov-io · 2020-10-17T17:44:07Z

Codecov Report

Merging #231 into master will decrease coverage by 0.17%.
The diff coverage is 29.41%.

@@ Coverage Diff @@## master #231 +/- ##
==========================================
- Coverage 83.40% 83.22% -0.18% 
==========================================
Files 31 31 Lines 1115 1121 +6 ==========================================
+ Hits 930 933 +3 - Misses 185 188 +3

Impacted Files	Coverage Δ
eax/src/online.rs	`0.00% <0.00%> (ø)`
eax/src/lib.rs	`90.90% <100.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4d072...8874ea1. Read the comment docs.

newpavlov

As a temporary solution it looks good to me, but in future I would prefer to have the "hazmat" methods discussed in the parent issue.

newpavlov · 2020-10-18T11:26:33Z

+
+impl TagSize for U1 {}
+impl TagSize for U2 {}
+impl TagSize for U3 {}


Are we sure we want to allow such short tags? Also I think it should be possible to specify a range bound using typenum without introducing the sealed trait (see typenum::type_operators), though the current approach is simple and easier to understand, so we can leave it as-is.

Implemented analogous to ccm by passing a second generic argument to Eax.

Flakebi · 2020-10-18T13:02:26Z

I changed the TagSize to be >= U4 and <= U16 and also put back the original eax::Tag alias, so the change should be backwards compatible.

tarcieri · 2020-10-18T14:52:22Z

@Flakebi LGTM, and matches the ccm crate

Flakebi · 2020-10-17T17:42:11Z

Implemented analogous to ccm by passing a second generic argument to
Eax.

Fixes#220.

This change should be mostly backwards compatible, apart from exporting the generic Tag instead of pub type Tag = GenericArray<u8, U16>;
It should be easy to make keep it completely backwards compatible if that’s better.

codecov-io · 2020-10-17T17:44:07Z

Codecov Report

Merging #231 into master will decrease coverage by 0.17%.
The diff coverage is 29.41%.

@@ Coverage Diff @@## master #231 +/- ##
==========================================
- Coverage 83.40% 83.22% -0.18% 
==========================================
Files 31 31 Lines 1115 1121 +6 ==========================================
+ Hits 930 933 +3 - Misses 185 188 +3

Impacted Files	Coverage Δ
eax/src/online.rs	`0.00% <0.00%> (ø)`
eax/src/lib.rs	`90.90% <100.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4d072...8874ea1. Read the comment docs.

newpavlov

As a temporary solution it looks good to me, but in future I would prefer to have the "hazmat" methods discussed in the parent issue.

newpavlov · 2020-10-18T11:26:33Z

+
+impl TagSize for U1 {}
+impl TagSize for U2 {}
+impl TagSize for U3 {}


Are we sure we want to allow such short tags? Also I think it should be possible to specify a range bound using typenum without introducing the sealed trait (see typenum::type_operators), though the current approach is simple and easier to understand, so we can leave it as-is.

Implemented analogous to ccm by passing a second generic argument to Eax.

Flakebi · 2020-10-18T13:02:26Z

I changed the TagSize to be >= U4 and <= U16 and also put back the original eax::Tag alias, so the change should be backwards compatible.

tarcieri · 2020-10-18T14:52:22Z

@Flakebi LGTM, and matches the ccm crate

Flakebi · 2020-10-17T17:42:11Z

Implemented analogous to ccm by passing a second generic argument to
Eax.

Fixes#220.

This change should be mostly backwards compatible, apart from exporting the generic Tag instead of pub type Tag = GenericArray<u8, U16>;
It should be easy to make keep it completely backwards compatible if that’s better.

codecov-io · 2020-10-17T17:44:07Z

Codecov Report

Merging #231 into master will decrease coverage by 0.17%.
The diff coverage is 29.41%.

@@ Coverage Diff @@## master #231 +/- ##
==========================================
- Coverage 83.40% 83.22% -0.18% 
==========================================
Files 31 31 Lines 1115 1121 +6 ==========================================
+ Hits 930 933 +3 - Misses 185 188 +3

Impacted Files	Coverage Δ
eax/src/online.rs	`0.00% <0.00%> (ø)`
eax/src/lib.rs	`90.90% <100.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4d072...8874ea1. Read the comment docs.

newpavlov

As a temporary solution it looks good to me, but in future I would prefer to have the "hazmat" methods discussed in the parent issue.

newpavlov · 2020-10-18T11:26:33Z

+
+impl TagSize for U1 {}
+impl TagSize for U2 {}
+impl TagSize for U3 {}


Are we sure we want to allow such short tags? Also I think it should be possible to specify a range bound using typenum without introducing the sealed trait (see typenum::type_operators), though the current approach is simple and easier to understand, so we can leave it as-is.

Implemented analogous to ccm by passing a second generic argument to Eax.

Flakebi · 2020-10-18T13:02:26Z

I changed the TagSize to be >= U4 and <= U16 and also put back the original eax::Tag alias, so the change should be backwards compatible.

tarcieri · 2020-10-18T14:52:22Z

@Flakebi LGTM, and matches the ccm crate

Flakebi force-pushed the partial-tag branch from ce1fdb2 to 8874ea1Compare October 17, 2020 17:43

tarcieri approved these changes Oct 17, 2020
View reviewed changes

tarcieri requested a review from newpavlov October 17, 2020 18:36

newpavlov mentioned this pull request Oct 18, 2020
Partial tag comparison #220
Closed

newpavlov approved these changes Oct 18, 2020
View reviewed changes

eax: Allow variable tag length
8b14d87
Implemented analogous to ccm by passing a second generic argument to Eax.

Flakebi force-pushed the partial-tag branch from 8874ea1 to 8b14d87Compare October 18, 2020 13:00

tarcieri merged commit 0a28591 into RustCrypto:masterOct 18, 2020

Flakebi deleted the partial-tag branch October 18, 2020 15:23

Flakebi mentioned this pull request Jan 9, 2021
eax: allow variable length nonces #239
Open

Flakebi mentioned this pull request Feb 25, 2021
Eax release #275
Closed

tarcieri mentioned this pull request Apr 30, 2021
eax v0.4.0 #299
Merged