Uh oh!
There was an error while loading. Please reload this page.
Conversation
tarcieri
commented
Oct 6, 2019
MemberAuthor
Looks like I broke I locally reverted it and all of the test vectors are now passing. |
tarcieri added a commit
to RustCrypto/universal-hashes
that referenced
this pull request
Oct 6, 2019
These changes broke the implementation of `mulX_POLYVAL`: https://github.com/RustCrypto/universal-hashes/pull/28/files#diff-6189716e3235b5dfb266bd1c39947b1aR95 After reverting it, AES-GCM test vectors which previously failed are now working: RustCrypto/AEADs#26
tarcieri
commented
Oct 6, 2019
MemberAuthor
With the bug in the I'd like to get all of them (well, with a 16-byte tag anyway) into the test vectors before merging. |
Taken from: <https://csrc.nist.gov/Projects/cryptographic-algorithm-validation-program/CAVP-TESTING-BLOCK-CIPHER-MODE> The included test vectors are those with a 96-bit nonce and 128-bit authentication tag.
tarcieri
commented
Oct 6, 2019
MemberAuthor
Just pushed the full set of NIST CAVS vectors (for a 96-bit nonce and 128-bit tag) and they're passing locally. |
tarcieri
commented
Oct 6, 2019
MemberAuthor
All NIST CAVS vectors are passing, so I'll call this good for a first pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently failing some of the NIST CAVS vectors for AES-256-GCM (commented out and marked as TODO).(fixed) All of the AES-128-GCM ones I've tried are working, though.It'd probably be good to extract all of the CAVS vectors for a 16-byte tag length and include them in the tests.