Uh oh!
There was an error while loading. Please reload this page.
Move AeadInPlace into Aead and add a const TAG_POSITION to AeadCore - #674
Closed
baloo wants to merge 18 commits into
Closed
Move AeadInPlace into Aead and add a const TAG_POSITION to AeadCore#674baloo wants to merge 18 commits into
AeadInPlace into Aead and add a const TAG_POSITION to AeadCore#674baloo wants to merge 18 commits into
Conversation
Replaces the previous `AeadInPlaceDetached` impls with `AeadInOut`, which was introduced in RustCrypto/traits#1793
baloo
marked this pull request as draft
March 18, 2025 18:30
balooforce-pushed
the
baloo/merged-trait
branch
5 times, most recently
from
March 19, 2025 19:19
708e976 to
4d428feCompareAeadInPlace into Aead and add a const TAG_POSITION to AeadCorebalooforce-pushed
the
baloo/merged-trait
branch
5 times, most recently
from
March 20, 2025 18:48
34c2d98 to
ce3ed4eComparenewpavlov
commented
Mar 21, 2025
Member
@baloo |
baloo
commented
Mar 21, 2025
MemberAuthor
yeah will do, but I will need a review on:
before we can merge that. |
MemberAuthor
Actually this gets included in #665 (still need a review on its dependencies) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is stacked on #665
See RustCrypto/traits#1798