Uh oh!
There was an error while loading. Please reload this page.
hkdf: simplify generic signatures - #155
Merged
Merged
Conversation
newpavlov
commented
Oct 13, 2025
MemberAuthor
We also could make the |
tarcieri
approved these changes
Oct 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
Merged
tarcieri added a commit
that referenced
this pull request
Mar 30, 2026
## Added - New `Hkdf` and `HkdfExtract` type aliases for `GenericHkdf` and `GenericHkdfExtract` (#155) - Implement `kdf::Kdf` for `GenericHkdfExtract` (#173) ## Changed - Bump MSRV to 1.85 and edition to 2024 (#114) - Bump `hmac` dependency to v0.13 - Use `digest::EagerHash` (#148) - Unseal `HmacImpl` trait (#154) - Rename `Hkdf` and `HkdfExtract` to `GenericHkdf` and `GenericHkdfExtract` respectively (#155) - Use simplified `H: HmacImpl` bounds (#155) ## Removed - `std` crate feature (#105)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
HkdfandHkdfExtracttoGenericHkdfandGenericHkdfExtractrespectively and simplifies their generic signature. Now the types are generic over single typeH: HmacImpl. It also removes the generic parameter from theHmacImpltrait.Finally, it introduces
HkdfExtractandHkdfaliases to simplify migration for users.