Minor post-transfer changes by newpavlov · Pull Request #1 · RustCrypto/RSA

newpavlov · 2018-12-03T09:58:50Z

Not sure about the minimum supported Rust version for CI, for now it's 1.27.

dignifiedquire

LGTM, thanks

newpavlov · 2018-12-03T10:27:04Z

If you would like to continue being the main maintainer (and developer) of this crate, then I think the one to merge PRs (including this one) should be you. What do you think?

dignifiedquire · 2018-12-03T10:27:43Z

If you would like to continue being the main maintainer (and developer) of this crate, then I think the one to merge PRs (including this one) should be you. What do you think?

Makes sense, will merge once CI is happy and publish an initial version to crates.io later today

newpavlov · 2018-12-03T10:33:19Z

key::tests::key_generation_128 has failed with "unwrap() on None". I've restarted the test and it got "fixed". IIUC you have non-determinism in your tests and implementation has a bug.

Ideally we should be able to use deterministic RNG source for tests and OS RNG for everything else, but unfortunately it's not that easy right now.

newpavlov · 2018-12-03T10:35:29Z

BTW it would be nice to also add fuzzing testing, see cargo-fuzz.

dignifiedquire · 2018-12-03T10:46:42Z

key::tests::key_generation_128 has failed with "unwrap() on None". I've restarted the test and it got "fixed". IIUC you have non-determinism in your tests and implementation has a bug.

Argh :/ I saw this once before in a project that uses this, but didn't realize it comes from here.

Created an issue #2

BTW it would be nice to also add fuzzing testing, see cargo-fuzz.

Yes, definitely need this #3

jarlungoodoo73

Delete all red lines, green lines are all go, there the fix. Review, fix, finish

Sign in to view

 [package]
 name = "rsa"
 version = "0.1.0"
-authors = ["dignifiedquire <dignifiedquire@gmail.com>"]


Sign in to view

 name = "rsa"
 version = "0.1.0"
-authors = ["dignifiedquire <dignifiedquire@gmail.com>"]
-description = "RSA implementation in Rust"


Sign in to view

+authors = ["RustCrypto Developers", "dignifiedquire <dignifiedquire@gmail.com>"]
+description = "Pure Rust RSA implementation"
 license = "MIT OR Apache-2.0"
-homepage = "https://github.com/dignifiedquire/rust-rsa"


Sign in to view

+description = "Pure Rust RSA implementation"
 license = "MIT OR Apache-2.0"
-homepage = "https://github.com/dignifiedquire/rust-rsa"
-repository = "https://github.com/dignifiedquire/rust-rsa"


Sign in to view

 license = "MIT OR Apache-2.0"
-homepage = "https://github.com/dignifiedquire/rust-rsa"
-repository = "https://github.com/dignifiedquire/rust-rsa"
-


Sign in to view

 # RSA
+[![crates.io](https://img.shields.io/crates/v/rsa.svg)](https://crates.io/crates/rsa) [![Documentation](https://docs.rs/rsa/badge.svg)](https://docs.rs/rsa) [![Build Status](https://travis-ci.org/RustCrypto/RSA.svg?branch=master)](https://travis-ci.org/RustCrypto/RSA) [![dependency status](https://deps.rs/repo/github/RustCrypto/RSA/status.svg)](https://deps.rs/repo/github/RustCrypto/RSA)

-> A portable RSA implementation in Rust.


Sign in to view


 ## License

-MIT or Apache 2.0


newpavlov added 2 commits December 3, 2018 12:57

post-transfer changes
6f8ac7a

fix badges and CI
7f6c596

newpavlov requested a review from dignifiedquire December 3, 2018 10:03

improve license section
2a93881

dignifiedquire approved these changes Dec 3, 2018
View reviewed changes

dignifiedquire mentioned this pull request Dec 3, 2018
Fix undeterminism #2
Closed

dignifiedquire merged commit d3e5d89 into masterDec 3, 2018

newpavlov deleted the transfer branch December 13, 2018 09:50

jarlungoodoo73 approved these changes Jan 20, 2026
View reviewed changes

Uh oh!

Conversation

newpavlov commented Dec 3, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dignifiedquire left a comment

Choose a reason for hiding this comment

Uh oh!

newpavlov commented Dec 3, 2018

Uh oh!

dignifiedquire commented Dec 3, 2018

Uh oh!

newpavlov commented Dec 3, 2018

Uh oh!

newpavlov commented Dec 3, 2018

Uh oh!

dignifiedquire commented Dec 3, 2018

Uh oh!

jarlungoodoo73 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

newpavlov commented Dec 3, 2018•
edited
Loading