Skip to content

Implement verify-only PSS PaddingScheme - #173

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
lumag:pss-verify
Aug 29, 2022
Merged

Implement verify-only PSS PaddingScheme#173
tarcieri merged 1 commit into
RustCrypto:masterfrom
lumag:pss-verify

Conversation

@lumag

@lumaglumag commented Jul 31, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

A fix for #172 , implementation of verify-only PSS padding schema

@tarcieri

tarcieri commented Jul 31, 2022

Copy link
Copy Markdown
Member

Instead of introducing a DummyRng, it seems to me like it would make more sense to remove salt_rng from PaddingScheme::PSS.

Its only use is to pass it to pss::sign, and in that regard it can be passed as an explicit parameter rather than embedding it into the padding scheme. An RNG is already an explicit parameter to sign_blinded (in which case it receives two RNGs. I'm not sure why one would want to use two RNGs?)

Really it'd be nice to implement the traits from the signature crate, where the "sign" vs "sign with RNG" cases are concretely handled as Signer versus RandomizedSigner, but that's a lot more work.

@lumag

lumag commented Jul 31, 2022

Copy link
Copy Markdown
ContributorAuthor

@tarcieri done

@lumag

lumag commented Aug 17, 2022

Copy link
Copy Markdown
ContributorAuthor

gracious ping

Dmitry Baryshkov
PaddingScheme: remove rng from PSS padding scheme (RustCrypto#172)
85d6256
The passed rng is not necessary for PSS signature verification. Instead
of passing artificial unused RNG through the PaddingScheme, add new
sign_with_rng() API and pass rng directly. In the sign_blinded() use the
passed rng both for salt generation and for the blinding process.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
@lumag

lumag commented Aug 23, 2022

Copy link
Copy Markdown
ContributorAuthor

Refreshed to remove conflict.

tarcieri
tarcieri approved these changes Aug 29, 2022
View reviewed changes

@tarcieritarcieri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better!

dignifiedquire
dignifiedquire approved these changes Aug 29, 2022
View reviewed changes

@dignifiedquiredignifiedquire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@tarcieri
tarcieri merged commit 2ffd3ae into RustCrypto:masterAug 29, 2022
@lumag
lumag deleted the pss-verify branch August 30, 2022 08:30
@Kriskras99

Kriskras99 commented Sep 14, 2022

Copy link
Copy Markdown

@tarcieri could this be included in the upcoming 0.7.0 release? It would save me a dependency and make it clearer what is going on in my code.

@tarcieri

tarcieri commented Sep 14, 2022

Copy link
Copy Markdown
Member

Yep, that's the plan

@Kriskras99

Kriskras99 commented Sep 14, 2022

Copy link
Copy Markdown

Yep, that's the plan

Great! I look forward to testing 0.7.0-pre2😁

@tarcieritarcieri mentioned this pull request Oct 10, 2022
Merged
takumi-earth pushed a commit to earthlings-dev/RSA that referenced this pull request Jan 27, 2026
Dmitry Baryshkov
PaddingScheme: remove rng from PSS padding scheme (RustCrypto#172) (R…
714e66d
…ustCrypto#173)
The passed rng is not necessary for PSS signature verification. Instead
of passing artificial unused RNG through the PaddingScheme, add new
sign_with_rng() API and pass rng directly. In the sign_blinded() use the
passed rng both for salt generation and for the blinding process.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes
@dignifiedquiredignifiedquiredignifiedquire approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lumag@tarcieri@Kriskras99@dignifiedquire