pkcs1v15: use AssociatedOID for getting the RSA prefix by lumag · Pull Request #183 · RustCrypto/RSA

lumag · 2022-09-09T12:58:20Z

Drop internal implementation of AssociatedHash and use AssociatedOID
trait to get the OID corresponding to the Digest and to format the ASN.1
prefix.

lumag · 2022-09-09T12:58:52Z

This depends on RustCrypto/traits#1098 and RustCrypto/hashes#405 to be merged first.

Add tests using RSA-SHA1 and RSA-SHA3-256 signature schemes. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Bump digest, sha1 and sha2 crates versions to resolve the OID/AssociatedOId implementations. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Drop internal implementation of AssociatedHash and use AssociatedOID trait to get the OID corresponding to the Digest and to format the ASN.1 prefix. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Fully replace rsa::Hash with AssociatedOid usage. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

lumag · 2022-09-16T07:11:08Z

@tarcieri @newpavlov Note, this pull request contains breaking change, it drops rsa::Hash. If you wish I can pull this commit out and leave only non-breaking changs.

tarcieri · 2022-09-16T13:56:37Z

@lumag breaking changes are fine as there are already ones merged (master is currently v0.7.0-pre)

newpavlov · 2022-09-16T16:04:10Z

It would be nice to update the changelog. It's easier to edit "unreleased" section, than to collect all changes introduced since previous release.

tarcieri · 2022-09-16T17:21:47Z

@newpavlov unfortunately there is no changelog! (#151)

But I'm happy to add one and document all of the changes in this (upcoming) release.

tarcieri · 2022-09-16T17:22:32Z

I'm going to go ahead and merge this as there are several people asking for an RC.

Can wait for feedback from @dignifiedquire before cutting a final release. And in the meantime, I can get a changelog added.

newpavlov · 2022-09-16T17:27:05Z

unfortunately there is no changelog

Ah, true. I think the next breaking release is a good opportunity to add one then.

dignifiedquire · 2022-09-18T12:08:50Z

Uhm, I am not sure I can support this, but from first glance this means I can't change the hash function at runtime, which is functionality I need. Or am I missing something?

dignifiedquire · 2022-09-18T12:10:24Z

 ];
 let pub_key: RsaPublicKey = priv_key.into();
- let verifying_key = VerifyingKey::<Sha256>::new_with_prefix(pub_key);
+ let verifying_key = VerifyingKey::<Sha1>::new_with_prefix(pub_key);


why did these get changed?

It was a revert of previous commit which changed Sha1 to Sha256.

lumag · 2022-09-18T16:15:44Z

Uhm, I am not sure I can support this, but from first glance this means I can't change the hash function at runtime, which is functionality I need. Or am I missing something?

Unfortunately changing the hash function at runtime doesn't match the SigningKey model. You can have several signing keys at once.

tarcieri · 2022-09-18T16:37:44Z

@dignifiedquire we could ensure the low-level APIs (defined in terms of RsaPrivateKey/RsaPublicKey) operate in terms of DynDigest and accept an ObjectIdentifier parameter where necessary. Does that work?

Re: SigningKey, using (Randomized)DigestSigner would at least reduce the part that needs to be monomorphized to the signing function itself, which would call into a common implementation once the digest has been computed.

An enum could be used to select the concrete Digest to use when invoking (Randomized)DigestSigner, although that could potentially be defined to represent a specific ciphersuite in a downstream crate, rather than in the rsa crate itself.

lumag · 2022-09-18T17:48:56Z

@dignifiedquire The SigningKey expects to get clear text, not the pre-hashed data. DigestSigningKey accepts Digest instance. I can implement the hazmat's interfaces to be able to accept prehashed texts. Or the old API is still accessible.

dignifiedquire · 2022-09-21T17:51:53Z

This is the code that I need to support: https://github.com/rpgp/rpgp/blob/master/src/crypto/rsa.rs#L67-L82
The hash function is supplied dynamically with a list of supported hashes here: https://github.com/rpgp/rpgp/blob/master/src/crypto/hash.rs#L45

dignifiedquire · 2022-09-21T17:55:01Z

I can implement the hazmat's interfaces to be able to accept prehashed texts

This specifically needs to support prehashed input. The linked api usage is 80% of the reason that I originally wrote this library. 😅

lumag · 2022-09-21T19:52:31Z

@dignifiedquire ack, I see the issue. I'll send a pull request in one of the forthcoming days.

dignifiedquire · 2022-09-21T21:04:02Z

thanks @lumag!

lumag · 2022-09-21T22:22:21Z

@dignifiedquire I've sketched rpgp/rpgp#193. However it might be easier to just restore the rsa::Hash struct and use old API as you have been using it up to now.

) Drop internal implementation of `AssociatedHash` and use `AssociatedOid` trait from `const_oid` to get the OID corresponding to the `Digest` and to format the ASN.1 prefix. Also removes the previous `Hash` enum as it was used for looking up OIDs. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

lumag mentioned this pull request Sep 9, 2022
digest: add implementations of the AssociatedOid trait RustCrypto/traits#1098
Merged

lumag force-pushed the rsa-oid branch 4 times, most recently from 4dcee07 to 6c62f69Compare September 12, 2022 15:03

tarcieri mentioned this pull request Sep 13, 2022
Removed ring dependency sigstore/sigstore-rs#127
Merged

lumag force-pushed the rsa-oid branch from 6c62f69 to 56315c4Compare September 16, 2022 02:12

lumag marked this pull request as ready for review September 16, 2022 02:13

newpavlov reviewed Sep 16, 2022
View reviewed changes

Comment threadCargo.toml Outdated

newpavlov reviewed Sep 16, 2022
View reviewed changes

Comment threadsrc/hash.rs

Dmitry Baryshkov added 4 commits September 16, 2022 10:08

pkcs1v15: Also test SHA1 and SHA3-256 prefixes
fa18521
Add tests using RSA-SHA1 and RSA-SHA3-256 signature schemes. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Cargo.toml: bump versions
5617d9c
Bump digest, sha1 and sha2 crates versions to resolve the OID/AssociatedOId implementations. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

pkcs1v15: use AssociatedOID for getting the RSA prefix
cdb5c2e
Drop internal implementation of AssociatedHash and use AssociatedOID trait to get the OID corresponding to the Digest and to format the ASN.1 prefix. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Get rid of rsa::Hash
53a085a
Fully replace rsa::Hash with AssociatedOid usage. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

lumag force-pushed the rsa-oid branch from 56315c4 to 53a085aCompare September 16, 2022 07:09

tarcieri requested a review from dignifiedquire September 16, 2022 13:55

tarcieri approved these changes Sep 16, 2022
View reviewed changes

tarcieri merged commit 92ef4c8 into RustCrypto:masterSep 16, 2022

dignifiedquire reviewed Sep 18, 2022
View reviewed changes

lumag deleted the rsa-oid branch October 8, 2022 19:18

tarcieri mentioned this pull request Oct 10, 2022
v0.7.0 #211
Merged

Uh oh!

Conversation

lumag commented Sep 9, 2022

Uh oh!

lumag commented Sep 9, 2022

Uh oh!

Uh oh!

Uh oh!

lumag commented Sep 16, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarcieri commented Sep 16, 2022

Uh oh!

newpavlov commented Sep 16, 2022

Uh oh!

tarcieri commented Sep 16, 2022

Uh oh!

tarcieri commented Sep 16, 2022

Uh oh!

newpavlov commented Sep 16, 2022

Uh oh!

dignifiedquire commented Sep 18, 2022

Uh oh!

dignifiedquireSep 18, 2022

Choose a reason for hiding this comment

Uh oh!

lumagSep 18, 2022

Choose a reason for hiding this comment

Uh oh!

lumag commented Sep 18, 2022

Uh oh!

tarcieri commented Sep 18, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lumag commented Sep 18, 2022

Uh oh!

dignifiedquire commented Sep 21, 2022

Uh oh!

dignifiedquire commented Sep 21, 2022

Uh oh!

lumag commented Sep 21, 2022

Uh oh!

dignifiedquire commented Sep 21, 2022

Uh oh!

lumag commented Sep 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lumag commented Sep 16, 2022•
edited
Loading

tarcieri commented Sep 18, 2022•
edited
Loading