Replace `Deref` impl on `RsaPrivateKey` with `AsRef` by tarcieri · Pull Request #317 · RustCrypto/RSA

tarcieri · 2023-04-27T14:28:00Z

The RsaPrivateKey type previously had a Deref impl providing access to the associated RsaPublicKey.

Deref is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases.

AsRef, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:40:35Z

FYI: this is the last change I have in mind prior to a v0.9.0 release

cc @lumag

lumag · 2023-04-27T15:49:06Z

@tarcieri please excuse me for missing several last PRs. I am at the conference now. They look good for me.

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:28:00Z

The RsaPrivateKey type previously had a Deref impl providing access to the associated RsaPublicKey.

Deref is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases.

AsRef, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:40:35Z

FYI: this is the last change I have in mind prior to a v0.9.0 release

cc @lumag

lumag · 2023-04-27T15:49:06Z

@tarcieri please excuse me for missing several last PRs. I am at the conference now. They look good for me.

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:28:00Z

The RsaPrivateKey type previously had a Deref impl providing access to the associated RsaPublicKey.

Deref is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases.

AsRef, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:40:35Z

FYI: this is the last change I have in mind prior to a v0.9.0 release

cc @lumag

lumag · 2023-04-27T15:49:06Z

@tarcieri please excuse me for missing several last PRs. I am at the conference now. They look good for me.

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:28:00Z

The RsaPrivateKey type previously had a Deref impl providing access to the associated RsaPublicKey.

Deref is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases.

AsRef, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:40:35Z

FYI: this is the last change I have in mind prior to a v0.9.0 release

cc @lumag

lumag · 2023-04-27T15:49:06Z

@tarcieri please excuse me for missing several last PRs. I am at the conference now. They look good for me.

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:28:00Z

The RsaPrivateKey type previously had a Deref impl providing access to the associated RsaPublicKey.

Deref is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases.

AsRef, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:40:35Z

FYI: this is the last change I have in mind prior to a v0.9.0 release

cc @lumag

lumag · 2023-04-27T15:49:06Z

@tarcieri please excuse me for missing several last PRs. I am at the conference now. They look good for me.

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:28:00Z

The RsaPrivateKey type previously had a Deref impl providing access to the associated RsaPublicKey.

Deref is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases.

AsRef, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:40:35Z

FYI: this is the last change I have in mind prior to a v0.9.0 release

cc @lumag

lumag · 2023-04-27T15:49:06Z

@tarcieri please excuse me for missing several last PRs. I am at the conference now. They look good for me.

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:28:00Z

The RsaPrivateKey type previously had a Deref impl providing access to the associated RsaPublicKey.

Deref is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases.

AsRef, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:40:35Z

FYI: this is the last change I have in mind prior to a v0.9.0 release

cc @lumag

lumag · 2023-04-27T15:49:06Z

@tarcieri please excuse me for missing several last PRs. I am at the conference now. They look good for me.

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:28:00Z

The RsaPrivateKey type previously had a Deref impl providing access to the associated RsaPublicKey.

Deref is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases.

AsRef, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).

tarcieri · 2023-04-27T14:40:35Z

FYI: this is the last change I have in mind prior to a v0.9.0 release

cc @lumag

lumag · 2023-04-27T15:49:06Z

@tarcieri please excuse me for missing several last PRs. I am at the conference now. They look good for me.

The `RsaPrivateKey` type previously had a `Deref` impl providing access to the associated `RsaPublicKey`. `Deref` is intended for "smart pointer types", i.e. container types which manage a (typically generic) inner type in some way. This doesn't seem like one of those cases. `AsRef`, on the other hand, is for cheap reference conversions, which is exactly what's happening here, so it's a better fit and provides the same functionality (albeit explicitly rather than via deref coercion).