Skip to content

ssh-key: have PublicKey and its parts implment Hash - #145

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
nresare:implement_Hash
Aug 11, 2023
Merged

ssh-key: have PublicKey and its parts implment Hash#145
tarcieri merged 1 commit into
RustCrypto:masterfrom
nresare:implement_Hash

Conversation

@nresare

@nresarenresare commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Implementing the Hash trait enables using PublicKeys and relatives as HashMap keys and in HashSets.

@nresare
nresareforce-pushed the implement_Hash branch 3 times, most recently from 3c16d43 to 2b50241CompareAugust 2, 2023 14:32
tarcieri
tarcieri reviewed Aug 6, 2023
View reviewed changes
Comment threadssh-key/src/public.rs Outdated
tarcieri
tarcieri reviewed Aug 6, 2023
View reviewed changes
Comment threadssh-key/src/mpint.rs
@nresare
ssh-key: have PublicKey and its parts implment Hash
9ab4475
This change derives the Hash trait for PublicKey and it's constitutent
parts. Since Mpint implements its own PartialEq, an explicit Hash
implmenetation delegating to the backing byte vector is added.
A test verifying that a HashSet containing a public key can
indeed be created and queried is also added.
@tarcieri
tarcieri merged commit acbcc7e into RustCrypto:masterAug 11, 2023
@tarcieri

tarcieri commented Aug 11, 2023

Copy link
Copy Markdown
Member

I'll probably do another pass over this before release, but the general idea can be supported

@tarcieritarcieri mentioned this pull request Aug 13, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nresare@tarcieri