Uh oh!
There was an error while loading. Please reload this page.
minimal-versions: replace workspace Cargo.toml instead of deleting - #51
Conversation
Generates a stub Cargo.toml at the workspace level which configures a workspace with one member whose path is the current working directory
Uh oh!
There was an error while loading. Please reload this page.
newpavlov
left a comment
There was a problem hiding this comment.
Ideally, it would be nice to modify only the members field and keep everything else in Cargo.toml. It would help with temporary patching since right now we have to disalbe minimal versions jobs when it present. But I guess we can improve it later.
Also note the failing lint.
Uh oh!
There was an error while loading. Please reload this page.
| @@ -0,0 +1,2 @@ | |||
| rules: | |||
| line-length: disable | |||
There was a problem hiding this comment.
IIRC it's possible to split run commands into multiple lines.
There was a problem hiding this comment.
I would rather not have to debug syntax issues in YAML configuration files because some lint is telling me every line must be 80 characters long, which is a silly restriction to begin with
Generates a stub Cargo.toml at the workspace level which configures a workspace with one member whose path is the current working directory.
I think this might resolve the problem I was having with using workspace-level configs in conjunction with
minimal-versionson RustCrypto/utils#1411Not sure how to test it