Skip to content

x509-cert: Load a chain of certificates from a slice - #1081

Merged
baloo merged 3 commits into
RustCrypto:masterfrom
baloo:x509-cert/chained-certificates
May 30, 2023
Merged

x509-cert: Load a chain of certificates from a slice#1081
baloo merged 3 commits into
RustCrypto:masterfrom
baloo:x509-cert/chained-certificates

Conversation

@baloo

Copy link
Copy Markdown
Member

This provides a Certificate::load_pem_chain helper to parse a chain of certificates.

See #11

@baloo

Copy link
Copy Markdown
MemberAuthor

Not exactly happy with this code, but I can't find a better way to implement it.

The way pem-rfc7468 is implemented makes it hard to implement there, Especially without breaking the constant time guaranties.

@baloo
balooforce-pushed the x509-cert/chained-certificates branch from 6735abd to da33bccCompareMay 24, 2023 03:46
Comment threadx509-cert/src/certificate.rs Outdated
@baloo
balooforce-pushed the x509-cert/chained-certificates branch 3 times, most recently from 6327185 to ed20156CompareMay 27, 2023 20:05
@baloo

Copy link
Copy Markdown
MemberAuthor

@tarcieri any opinion? If you're okay I'll merge this and cut a release of x509-cert

Comment threadx509-cert/tests/examples/crates.io-chain.pem
@baloo
balooforce-pushed the x509-cert/chained-certificates branch from ed20156 to a2cef08CompareMay 30, 2023 16:53
Comment threadx509-cert/tests/examples/crates.io-chain.pem

@tarcieritarcieri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving with the changes. I think I'm actually done with suggestions now 😉

@baloo
baloo merged commit 245f7d2 into RustCrypto:masterMay 30, 2023
@baloo
baloo deleted the x509-cert/chained-certificates branch May 30, 2023 17:33
baloo added a commit to baloo/formats that referenced this pull request May 30, 2023
Added
- Added `TryFrom` for `RelativeDistinguishedName` ([RustCrypto#1092])
- Load a chain of certificates from a slice ([RustCrypto#1081])
@baloobaloo mentioned this pull request May 30, 2023
baloo added a commit to baloo/formats that referenced this pull request May 30, 2023
Added
- Added `TryFrom` for `RelativeDistinguishedName` ([RustCrypto#1092])
- Load a chain of certificates from a slice ([RustCrypto#1081])
baloo added a commit that referenced this pull request May 30, 2023
Added
- Added `TryFrom` for `RelativeDistinguishedName` ([#1092])
- Load a chain of certificates from a slice ([#1081])
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@baloo@tarcieri