Uh oh!
There was an error while loading. Please reload this page.
cms: Don't insert signing time attribute by default. - #1148
Merged
Conversation
Merged
tarcieri
approved these changes
Jul 11, 2023
baloo
approved these changes
Jul 11, 2023
baloo
left a comment
Member
There was a problem hiding this comment.
I don't see a requirement to have it included by default in RFC 5652
carl-wallace
approved these changes
Jul 12, 2023
carl-wallace
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me (and worked in context of the SCEP usage I mentioned before). I had a question re: whether always using signed attributes was OK but nothing in 5652 compels one to not use content type and message digest attributes, so this seems fine.
baloo added a commit
to baloo/formats
that referenced
this pull request
Jul 14, 2023
Added - `SignedData` builder (RustCrypto#1051) Changed - Deprecate `pkcs7` in favor of `cms` (RustCrypto#1062) - der: add `SetOf(Vec)::insert(_ordered)`; deprecate `add` (RustCrypto#1067) - Re-enable all minimal-versions checks (RustCrypto#1071) Fixed - Don't insert signing time attribute by default (RustCrypto#1148) - Fixed encoding of `SubjectKeyIdentifier` (RustCrypto#1152)
Merged
baloo added a commit
that referenced
this pull request
Jul 14, 2023
Added - `SignedData` builder (#1051) Changed - Deprecate `pkcs7` in favor of `cms` (#1062) - der: add `SetOf(Vec)::insert(_ordered)`; deprecate `add` (#1067) - Re-enable all minimal-versions checks (#1071) Fixed - Don't insert signing time attribute by default (#1148) - Fixed encoding of `SubjectKeyIdentifier` (#1152)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
SignedDataBuilderinserted a signing time attribute by default. This was removed, as it is not required ans might even be unwanted.