Uh oh!
There was an error while loading. Please reload this page.
pkcs5: Make storage generic - #1193
Closed
baloo wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
baloo
commented
Aug 8, 2023
MemberAuthor
I'm not exactly happy with the result. I don't quite like the complexity of it. |
tarcieri
commented
Aug 8, 2023
Member
I had a very different idea about how to approach this which does not involve any generic type parameters. I can open a separate PR. |
tarcieri
commented
Aug 9, 2023
Member
Opened a PR which makes all of the types owned with no generic parameters: #1195 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1117