Uh oh!
There was an error while loading. Please reload this page.
Add support for 64-bit moduli - #1649
Conversation
Ugh, not super wild about this. Generally the whole |
dvdplm
commented
Feb 7, 2025
Could moving it to a |
fjarri
commented
Feb 7, 2025
Is this kind of hand-holding really needed? It's still pretty easy to make an unsafe curve even with 192-bit elements. |
fjarri
commented
Feb 7, 2025
Also, in case this misuse protection was not the primary purpose of pubtraitSec1Sizes{// or whatever nametypeModulusSize:ArrayLength<u8>;typeCompressedPointSize:ArrayLength<u8>;
...
}I don't think it will restrict any current upstream usage, but it will allow one to define their own |
tarcieri
commented
Feb 7, 2025
@fjarri I'd be fine with some way of letting crates define their own downstream SEC1 size combinations if it can be made to work with the |
Seems that |
tarcieri
commented
Feb 8, 2025
Let's go with #1650 |
The
tiny-curvecrate uses 64-bitFieldBytesSize, and when used in combination with theFromEncodedPointtrait, there's a problem with a missing impl of theModulusSizetrait.Adding
U8to the list of impl'd types should fix this.