Skip to content

x509-cert: add DirectoryString::BmpString - #1794

Merged
baloo merged 3 commits into
RustCrypto:masterfrom
dishmaker:dishmaker/x509_cert_add_bmpstring
Jun 5, 2025
Merged

x509-cert: add DirectoryString::BmpString#1794
baloo merged 3 commits into
RustCrypto:masterfrom
dishmaker:dishmaker/x509_cert_add_bmpstring

Conversation

@dishmaker

@dishmakerdishmaker commented May 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

dishmaker
dishmaker commented May 2, 2025
View reviewed changes
Comment threadx509-cert/src/ext/pkix/name/dirstr.rs
@dishmaker
dishmakerforce-pushed the dishmaker/x509_cert_add_bmpstring branch from 25f4c88 to 3c1a63cCompareMay 2, 2025 21:46
@dishmaker

dishmaker commented May 5, 2025

Copy link
Copy Markdown
ContributorAuthor

Maybe let's add as_ref without trait and #[deprecate] it ?

@tarcieri

tarcieri commented May 5, 2025

Copy link
Copy Markdown
Member

@dishmaker that works

@tarcieri

tarcieri commented May 5, 2025

Copy link
Copy Markdown
Member

Maybe also add a ToString impl and a From<DirectoryString> for String impl? (you will need to silence clippy for the former IIRC)

@dishmaker
x509-cert: add DirectoryString::BmpString
f987ab7
x509-cert: use alloc instead of std
x509-cert: apply clippy Cow<'_, str>
x509-cert: fix test decode_cert_bmpstring
@dishmaker
x509-cert: remove DirectoryString::as_ref
611057e
@dishmaker
x509-cert: add deprecated as_ref and `From<DirectoryString> for Str…
a0fb1e4
…ing`
@dishmaker
dishmakerforce-pushed the dishmaker/x509_cert_add_bmpstring branch from 681b6e1 to a0fb1e4CompareMay 6, 2025 12:45
baloo
baloo reviewed Jun 5, 2025
View reviewed changes
Comment threadx509-cert/src/ext/pkix/name/dirstr.rs
@baloo
baloo merged commit 2bb97f6 into RustCrypto:masterJun 5, 2025
baloo added a commit to baloo/formats that referenced this pull request Jul 6, 2026
@baloo
x509-cert: v0.3.0
a4b3ed7
Added
- Serial number generator ([RustCrypto#1270])
- `DecodeValue` for `x509_cert::time::Time` ([RustCrypto#1986])
- `FromStr` for `x509_cert::time::Time` ([RustCrypto#1961])
- impl `Hash` for `Name` ([RustCrypto#1764])
- impl `Ord` for `CrlReason` ([RustCrypto#1869])
- `DirectoryString::BmpString` ([RustCrypto#1794])
- `Crl` builder ([RustCrypto#1759])
- `Time::now` method ([RustCrypto#1761])
- `Validity::infinity` helper ([RustCrypto#1528])
- `Validity::new` method ([RustCrypto#1529])
- Re-export `spki` types without `*Owned` suffixes ([RustCrypto#1534])
- `x509_cert::builder::AsyncBuilder` using `AsyncSigner` ([RustCrypto#1280])
Changed
- Decompose `AsExtension` into `Criticality + AsExtension` ([RustCrypto#2109])
- Improve extension API flexibility and ergonomics ([RustCrypto#2120])
- Expose `Profile` in the `CrlBuilder` ([RustCrypto#1870])
- Ensure a serial number can be stored in a database ([RustCrypto#1868])
- Move the CSR builder `x509_cert::request` ([RustCrypto#1581])
- Rename `x509_cert::builder::Profile` to `BuilderProfile` ([RustCrypto#1514] && [RustCrypto#1517])
- `Name` is now a new type over `RdnSequence` ([RustCrypto#1499])
- make `RelativeDistinguishedName` fields private ([RustCrypto#1510])
- make `RdnSequence` fields private ([RustCrypto#1508])
- make (Tbs)`CertificateInner` fields private ([RustCrypto#1505])
- rename helpers to `get_extension`/`filter_extensions` ([RustCrypto#1497])
- `check_name_encoding` now allow extraneous components ([RustCrypto#1447])
- Accept RFC-invalid certificates as TrustAnchors ([RustCrypto#1403])
- Edition changed to 2024 and MSRV bumped to 1.85 ([RustCrypto#1689])
- Bump `rand` to `v0.10` ([RustCrypto#2212])
- Bump `der` to `v0.8` ([RustCrypto#2234])
- Bump `digest` to `v0.11` ([RustCrypto#2237])
- Bump `sha2` to `v0.11` ([RustCrypto#2273])
- Bump `spki` to `v0.8` ([RustCrypto#2277])
- Bump `signature` to `v3` ([RustCrypto#2326])
Fixed
- Converting from `SystemTime` should use `UtcTime` if date <= 2049 ([RustCrypto#1969])
- Underflow on empty input in `Certificate::load_pem_chain` ([RustCrypto#1965])
- Domain validated should accept CNs ([RustCrypto#1815])
- Serialization of email addresses ([RustCrypto#1425])
Removed
- Std requirement for `x509_cert::builder` ([RustCrypto#1709])
- `RelativeDistinguishedName::encode_from_string` ([RustCrypto#1509])
[RustCrypto#1270]: RustCrypto#1270
[RustCrypto#1280]: RustCrypto#1280
[RustCrypto#1403]: RustCrypto#1403
[RustCrypto#1425]: RustCrypto#1425
[RustCrypto#1447]: RustCrypto#1447
[RustCrypto#1497]: RustCrypto#1497
[RustCrypto#1499]: RustCrypto#1499
[RustCrypto#1505]: RustCrypto#1505
[RustCrypto#1508]: RustCrypto#1508
[RustCrypto#1509]: RustCrypto#1509
[RustCrypto#1510]: RustCrypto#1510
[RustCrypto#1514]: RustCrypto#1514
[RustCrypto#1517]: RustCrypto#1517
[RustCrypto#1528]: RustCrypto#1528
[RustCrypto#1529]: RustCrypto#1529
[RustCrypto#1534]: RustCrypto#1534
[RustCrypto#1581]: RustCrypto#1581
[RustCrypto#1689]: RustCrypto#1689
[RustCrypto#1709]: RustCrypto#1709
[RustCrypto#1759]: RustCrypto#1759
[RustCrypto#1761]: RustCrypto#1761
[RustCrypto#1764]: RustCrypto#1764
[RustCrypto#1794]: RustCrypto#1794
[RustCrypto#1815]: RustCrypto#1815
[RustCrypto#1868]: RustCrypto#1868
[RustCrypto#1869]: RustCrypto#1869
[RustCrypto#1870]: RustCrypto#1870
[RustCrypto#1961]: RustCrypto#1961
[RustCrypto#1965]: RustCrypto#1965
[RustCrypto#1969]: RustCrypto#1969
[RustCrypto#1986]: RustCrypto#1986
[RustCrypto#2109]: RustCrypto#2109
[RustCrypto#2120]: RustCrypto#2120
[RustCrypto#2212]: RustCrypto#2212
[RustCrypto#2234]: RustCrypto#2234
[RustCrypto#2237]: RustCrypto#2237
[RustCrypto#2273]: RustCrypto#2273
[RustCrypto#2277]: RustCrypto#2277
[RustCrypto#2326]: RustCrypto#2326
@baloobaloo mentioned this pull request Jul 6, 2026
Merged
baloo added a commit to baloo/formats that referenced this pull request Jul 6, 2026
@baloo
x509-cert: v0.3.0
4c3d35f
Added
- Serial number generator ([RustCrypto#1270])
- `DecodeValue` for `x509_cert::time::Time` ([RustCrypto#1986])
- `FromStr` for `x509_cert::time::Time` ([RustCrypto#1961])
- impl `Hash` for `Name` ([RustCrypto#1764])
- impl `Ord` for `CrlReason` ([RustCrypto#1869])
- `DirectoryString::BmpString` ([RustCrypto#1794])
- `Crl` builder ([RustCrypto#1759])
- `Time::now` method ([RustCrypto#1761])
- `Validity::infinity` helper ([RustCrypto#1528])
- `Validity::new` method ([RustCrypto#1529])
- Re-export `spki` types without `*Owned` suffixes ([RustCrypto#1534])
- `x509_cert::builder::AsyncBuilder` using `AsyncSigner` ([RustCrypto#1280])
Changed
- Decompose `AsExtension` into `Criticality + AsExtension` ([RustCrypto#2109])
- Improve extension API flexibility and ergonomics ([RustCrypto#2120])
- Expose `Profile` in the `CrlBuilder` ([RustCrypto#1870])
- Ensure a serial number can be stored in a database ([RustCrypto#1868])
- Move the CSR builder `x509_cert::request` ([RustCrypto#1581])
- Rename `x509_cert::builder::Profile` to `BuilderProfile` ([RustCrypto#1514] && [RustCrypto#1517])
- `Name` is now a new type over `RdnSequence` ([RustCrypto#1499])
- make `RelativeDistinguishedName` fields private ([RustCrypto#1510])
- make `RdnSequence` fields private ([RustCrypto#1508])
- make (Tbs)`CertificateInner` fields private ([RustCrypto#1505])
- rename helpers to `get_extension`/`filter_extensions` ([RustCrypto#1497])
- `check_name_encoding` now allow extraneous components ([RustCrypto#1447])
- Accept RFC-invalid certificates as TrustAnchors ([RustCrypto#1403])
- Edition changed to 2024 and MSRV bumped to 1.85 ([RustCrypto#1689])
- Bump `rand` to `v0.10` ([RustCrypto#2212])
- Bump `der` to `v0.8` ([RustCrypto#2234])
- Bump `digest` to `v0.11` ([RustCrypto#2237])
- Bump `sha2` to `v0.11` ([RustCrypto#2273])
- Bump `spki` to `v0.8` ([RustCrypto#2277])
- Bump `signature` to `v3` ([RustCrypto#2326])
Fixed
- Converting from `SystemTime` should use `UtcTime` if date <= 2049 ([RustCrypto#1969])
- Underflow on empty input in `Certificate::load_pem_chain` ([RustCrypto#1965])
- Domain validated should accept CNs ([RustCrypto#1815])
- Serialization of email addresses ([RustCrypto#1425])
Removed
- Std requirement for `x509_cert::builder` ([RustCrypto#1709])
- `RelativeDistinguishedName::encode_from_string` ([RustCrypto#1509])
[RustCrypto#1270]: RustCrypto#1270
[RustCrypto#1280]: RustCrypto#1280
[RustCrypto#1403]: RustCrypto#1403
[RustCrypto#1425]: RustCrypto#1425
[RustCrypto#1447]: RustCrypto#1447
[RustCrypto#1497]: RustCrypto#1497
[RustCrypto#1499]: RustCrypto#1499
[RustCrypto#1505]: RustCrypto#1505
[RustCrypto#1508]: RustCrypto#1508
[RustCrypto#1509]: RustCrypto#1509
[RustCrypto#1510]: RustCrypto#1510
[RustCrypto#1514]: RustCrypto#1514
[RustCrypto#1517]: RustCrypto#1517
[RustCrypto#1528]: RustCrypto#1528
[RustCrypto#1529]: RustCrypto#1529
[RustCrypto#1534]: RustCrypto#1534
[RustCrypto#1581]: RustCrypto#1581
[RustCrypto#1689]: RustCrypto#1689
[RustCrypto#1709]: RustCrypto#1709
[RustCrypto#1759]: RustCrypto#1759
[RustCrypto#1761]: RustCrypto#1761
[RustCrypto#1764]: RustCrypto#1764
[RustCrypto#1794]: RustCrypto#1794
[RustCrypto#1815]: RustCrypto#1815
[RustCrypto#1868]: RustCrypto#1868
[RustCrypto#1869]: RustCrypto#1869
[RustCrypto#1870]: RustCrypto#1870
[RustCrypto#1961]: RustCrypto#1961
[RustCrypto#1965]: RustCrypto#1965
[RustCrypto#1969]: RustCrypto#1969
[RustCrypto#1986]: RustCrypto#1986
[RustCrypto#2109]: RustCrypto#2109
[RustCrypto#2120]: RustCrypto#2120
[RustCrypto#2212]: RustCrypto#2212
[RustCrypto#2234]: RustCrypto#2234
[RustCrypto#2237]: RustCrypto#2237
[RustCrypto#2273]: RustCrypto#2273
[RustCrypto#2277]: RustCrypto#2277
[RustCrypto#2326]: RustCrypto#2326
tarcieri added a commit that referenced this pull request Jul 9, 2026
@baloo@tarcieri
x509-cert v0.3.0 (#2375)
c478c6b
## Added
- Serial number generator (#1270)
- `DecodeValue` for `x509_cert::time::Time` (#1986)
- `FromStr` for `x509_cert::time::Time` (#1961)
- impl `Hash` for `Name` (#1764)
- impl `Ord` for `CrlReason` (#1869)
- `DirectoryString::BmpString` (#1794)
- `Crl` builder (#1759)
- `Time::now` method (#1761)
- `Validity::infinity` helper (#1528)
- `Validity::new` method (#1529)
- Re-export `spki` types without `*Owned` suffixes (#1534)
- `x509_cert::builder::AsyncBuilder` using `AsyncSigner` (#1280)
## Changed
- Decompose `AsExtension` into `Criticality + AsExtension` (#2109)
- Improve extension API flexibility and ergonomics (#2120)
- Expose `Profile` in the `CrlBuilder` (#1870)
- Ensure a serial number can be stored in a database (#1868)
- Move the CSR builder `x509_cert::request` (#1581)
- Rename `x509_cert::builder::Profile` to `BuilderProfile` (#1514, #1517)
- `Name` is now a new type over `RdnSequence` (#1499)
- make `RelativeDistinguishedName` fields private (#1510)
- make `RdnSequence` fields private (#1508)
- make (Tbs)`CertificateInner` fields private (#1505)
- rename helpers to `get_extension`/`filter_extensions` (#1497)
- `check_name_encoding` now allow extraneous components (#1447)
- Accept RFC-invalid certificates as TrustAnchors (#1403)
- Edition changed to 2024 and MSRV bumped to 1.85 (#1689)
- Bump `rand` to `v0.10` (#2212)
- Bump `der` to `v0.8` (#2234)
- Bump `digest` to `v0.11` (#2237)
- Bump `sha2` to `v0.11` (#2273)
- Bump `spki` to `v0.8` (#2277)
- Bump `signature` to `v3` (#2326)
## Fixed
- Converting from `SystemTime` should use `UtcTime` if date <= 2049 (#1969)
- Underflow on empty input in `Certificate::load_pem_chain` (#1965)
- Domain validated should accept CNs (#1815)
- Serialization of email addresses (#1425)
## Removed
- `std` requirement for `x509_cert::builder` (#1709)
- `RelativeDistinguishedName::encode_from_string` (#1509)
Co-authored-by: Tony Arcieri <bascule@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri left review comments
@baloobaloobaloo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

x509-cert: BMPString support for DirectoryString

3 participants

@dishmaker@tarcieri@baloo