Uh oh!
There was an error while loading. Please reload this page.
der: add test for derive Sequence with IMPLICIT SequenceRef - #2010
der: add test for derive Sequence with IMPLICIT SequenceRef#2010dishmaker wants to merge 3 commits into
Conversation
| impl<'a> SequenceRef<'a> { | ||
| /// Create a new [`SequenceRef`] from the provided DER bytes. | ||
| pub fn new(slice: &'a [u8]) -> Result<Self> { |
There was a problem hiding this comment.
This is one I don't understand.
How does that not break invariants?
SequenceRef::from_der should already work? I'm missing something.
There was a problem hiding this comment.
from_der would parse tag and length first, then the contents.
There was a problem hiding this comment.
Yeah, they do two different things: from_der would need the tag/length header, where this is just the "value" portion sans header
There was a problem hiding this comment.
That makes more sense.
But then I would say the comment could probably use an update (as is, it would definitely have tripped me up).
Something like /// Create a new [SequenceRef] from the DER bytes of the inner value or something along those lines.
tarcieri
commented
Feb 11, 2026
Closing as stale |
Depends on #1980