Skip to content

der: add DecodeValue::decode_value_nested - #2011

Closed
dishmaker wants to merge 1 commit into
RustCrypto:masterfrom
dishmaker:dishmaker/der_decode_value_nested
Closed

der: add DecodeValue::decode_value_nested#2011
dishmaker wants to merge 1 commit into
RustCrypto:masterfrom
dishmaker:dishmaker/der_decode_value_nested

Conversation

@dishmaker

@dishmakerdishmaker commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

This PR moves read_nested out of pub(crate) fn read_value.

Such trait function allows us to disable read_nested selectively for some primitive types, like OctetStringRef.

@tarcieri

Copy link
Copy Markdown
Member

@dishmaker have you benchmarked what the actual impact of this is?

@dishmaker

Copy link
Copy Markdown
ContributorAuthor

I did not benchmark it.

@dishmaker

Copy link
Copy Markdown
ContributorAuthor

Need to benchmark this and rebase

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dishmaker@tarcieri