Uh oh!
There was an error while loading. Please reload this page.
Allow TstInfo to read GeneralizedTime with subseconds - #2063
Merged
Conversation
roblablaforce-pushed
the
generalized-time-subsecs-tsp
branch
2 times, most recently
from
October 10, 2025 11:36
1a9b484 to
c503b72CompareUh oh!
There was an error while loading. Please reload this page.
Contributor
What about |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Also test:
|
tarcieri
commented
Oct 10, 2025
Member
I’d agree the |
roblabla
commented
Oct 10, 2025
ContributorAuthor
Yeah I expected some bikeshedding around the name ^^. |
roblablaforce-pushed
the
generalized-time-subsecs-tsp
branch
2 times, most recently
from
October 10, 2025 15:33
35af114 to
a6aa469Comparebaloo
reviewed
Oct 10, 2025
Uh oh!
There was an error while loading. Please reload this page.
dishmaker
commented
Oct 10, 2025
Contributor
Oh. I thought you'd make a test loop 0..=9 😅 |
roblablaforce-pushed
the
generalized-time-subsecs-tsp
branch
3 times, most recently
from
October 10, 2025 18:56
38bcbb8 to
c71a7e7Compareroblablaforce-pushed
the
generalized-time-subsecs-tsp
branch
from
October 10, 2025 18:58
c71a7e7 to
132c9c9Comparebaloo
approved these changes
Oct 11, 2025
Uh oh!
There was an error while loading. Please reload this page.
roblabla added a commit
to JustRustThings/formats
that referenced
this pull request
Oct 14, 2025
roblabla added a commit
to JustRustThings/formats
that referenced
this pull request
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new type GeneralizedTimeWithSubseconds which allows parsing a GeneralizedTime according to the DER restrictions and not the RFC5280 restrictions - meaning it can get subseconds.
The type is added to x509-tsp since that is the only known user of the type, though maybe it'd be more appropriate to move it to
der? (That would allow it to share some of the decoder functions with GeneralizedTime).Internally, it's represented as a
DateTime(The same internal type used by GeneralizedTime) and an additional nanoseconds u32. We don't parse subseconds more precise than NS precision - that felt like an appropriate cutoff point.CC #365