Uh oh!
There was an error while loading. Please reload this page.
der: error on nested trailing data - #2401
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: dishmaker <141624503+dishmaker@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
karalabe
commented
Aug 28, 2026
Any chance of cutting a release with this one? Kind of borks the latest release. |
karalabe added a commit
to dark-bio/crypto-rs
that referenced
this pull request
Aug 28, 2026
This PR fixes a DER decoding issue that worked until now, just used the wrong types. That ended up hitting a regression in the upstream `der` crate (RustCrypto/formats#2401), causing an invalid decode. Whilst the upstream fix would also hide this issue, this PR also resolves it differently too by using non-nested types. Apart of that, it also adds some extra validation to ensure certain DER items ignored until now get flat out rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #2378 which would silently ignore trailing data inside of nested DER messages.
Closes#2391