Skip to content

Implement context-specific tags on #[derive(Sequence)] - #349

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
bstrie:implicitseqder
Jan 25, 2022
Merged

Implement context-specific tags on #[derive(Sequence)]#349
tarcieri merged 1 commit into
RustCrypto:masterfrom
bstrie:implicitseqder

Conversation

@bstrie

@bstriebstrie commented Jan 21, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.

If you'd like I would be happy to add more tests to cover the interactions between the various options, but I admit that I'm not an ASN.1 expert so I would need some guidance as to how these options interact so that I could formulate the correct desugaring.

Closes#322.

This was referenced Jan 21, 2022
Closed
Closed
@npmccallum

npmccallum commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

@bstrie I think you mean context specific, not context sensitive.

@tarcieri

tarcieri commented Jan 21, 2022

Copy link
Copy Markdown
Member

I think you mean context specific, not context sensitive

Thanks to the Chomsky Hierarchy I have made this mistake several times myself 😅

tarcieri
tarcieri reviewed Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/choice/variant.rs
@bstriebstrie changed the title Implement context-sensitive tags on #[derive(Sequence)]Implement context-specific tags on #[derive(Sequence)]Jan 21, 2022
@npmccallum

npmccallum commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

@bstrie I think you need to fix the commit message wording too.

@npmccallum

npmccallum commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

@bstrie Also, one of the tests is failing.

@tarcieri

tarcieri commented Jan 21, 2022•
edited
Loading

Copy link
Copy Markdown
Member

One of the errors is on IssuingDistributionPointsExample:

impl::der::Sequence<'_>forIssuingDistributionPointExample{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}

...not sure what's happening there but the empty tuple is definitely not the right result.

Looks like something similar on the other error:

impl<'a>::der::Sequence<'a>forOneAsymmetricKey<'a>{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}

Perhaps the unparseable tokens are being lost?

error: proc-macro derive produced unparseable tokens

tarcieri
tarcieri reviewed Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs Outdated
tarcieri
tarcieri reviewed Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs Outdated
@bstrie
Implement context-specific tags on #[derive(Sequence)]
b79f7ac
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@bstrie

bstrie commented Jan 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Code updated to pass all the tests (sorry about not doing so the first time, I forgot to test with --all-features). The tests that were failing were already using context-specific tags (which I guess were just being ignored before now) in conjunction with various other field attributes. Taking into account all the supported combinations of the currently-implemented attributes was a bit tricky and required some subtle changes to make sure all the references lined up correctly, but in the end I think I managed to find a nice arrangement that doesn't involve adding state to the Lowerer or else compromising the unit-testability of the Lowerer methods. Once again I tested this with #323 to confirm that it addresses #322 .

tarcieri
tarcieri reviewed Jan 25, 2022
View reviewed changes
Comment threadder/tests/derive.rs

#[derive(Sequence)]
#[asn1(tag_mode = "IMPLICIT")]
pub struct TypeCheckExpandedSequenceFieldAttributeCombinations<'a> {

@tarcieritarcieriJan 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 😅

@bstriebstrieJan 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call that "self-documenting code". :P

@tarcieri
tarcieri merged commit 0c416e9 into RustCrypto:masterJan 25, 2022
npmccallum pushed a commit to npmccallum/formats that referenced this pull request Jan 27, 2022
@bstrie@npmccallum
Implement context-specific tags on #[derive(Sequence)] (RustCrypto#349)
e191b99
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@tarcieritarcieri mentioned this pull request May 8, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

der crate fails to emit implicit context-specific tags on SET

3 participants

@bstrie@npmccallum@tarcieri
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Implement context-specific tags on #[derive(Sequence)] by bstrie · Pull Request #349 · RustCrypto/formats · GitHub
Skip to content
Implement context-specific tags on #[derive(Sequence)] - #349
Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Jan 25, 2022
Merged
Implement context-specific tags on #[derive(Sequence)]#349
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Conversation
@bstrie
@bstriebstrie
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
If you'd like I would be happy to add more tests to cover the interactions between the various options, but I admit that I'm not an ASN.1 expert so I would need some guidance as to how these options interact so that I could formulate the correct desugaring.
Closes#322.

This was referenced Jan 21, 2022

Closed


Closed

@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you mean context specific, not context sensitive.
@tarcieri
tarcieri
commented
Jan 21, 2022

Copy link


Copy Markdown

Member
I think you mean context specific, not context sensitive
Thanks to the Chomsky Hierarchy I have made this mistake several times myself 😅
tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/choice/variant.rs
@bstriebstrie
changed the title
Implement context-sensitive tags on #[derive(Sequence)]Implement context-specific tags on #[derive(Sequence)]Jan 21, 2022
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you need to fix the commit message wording too.
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie Also, one of the tests is failing.
@tarcieri
tarcieri
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
One of the errors is on IssuingDistributionPointsExample:
impl::der::Sequence<'_>forIssuingDistributionPointExample{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
...not sure what's happening there but the empty tuple is definitely not the right result.
Looks like something similar on the other error:
impl<'a>::der::Sequence<'a>forOneAsymmetricKey<'a>{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
Perhaps the unparseable tokens are being lost?
error: proc-macro derive produced unparseable tokens

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

@bstrie
Implement context-specific tags on #[derive(Sequence)]
b79f7ac
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@bstrie
bstrie
commented
Jan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Code updated to pass all the tests (sorry about not doing so the first time, I forgot to test with --all-features). The tests that were failing were already using context-specific tags (which I guess were just being ignored before now) in conjunction with various other field attributes. Taking into account all the supported combinations of the currently-implemented attributes was a bit tricky and required some subtle changes to make sure all the references lined up correctly, but in the end I think I managed to find a nice arrangement that doesn't involve adding state to the Lowerer or else compromising the unit-testability of the Lowerer methods. Once again I tested this with #323 to confirm that it addresses #322 .
tarcieri
tarcieri
reviewed
Jan 25, 2022
View reviewed changes
Comment threadder/tests/derive.rs

 #[derive(Sequence)]
 #[asn1(tag_mode = "IMPLICIT")]
 pub struct TypeCheckExpandedSequenceFieldAttributeCombinations<'a> {
@tarcieritarcieriJan 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 😅
@bstriebstrieJan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call that "self-documenting code". :P
@tarcieri
tarcieri
merged commit 0c416e9
into
RustCrypto:masterJan 25, 2022
npmccallum pushed a commit
to npmccallum/formats
that referenced
this pull request
Jan 27, 2022
@bstrie@npmccallum
Implement context-specific tags on #[derive(Sequence)] (RustCrypto#349)
e191b99
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@tarcieritarcieri
mentioned this pull request
May 8, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.
der crate fails to emit implicit context-specific tags on SET

3 participants

@bstrie@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Implement context-specific tags on #[derive(Sequence)] by bstrie · Pull Request #349 · RustCrypto/formats · GitHub
Skip to content
Implement context-specific tags on #[derive(Sequence)] - #349
Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Jan 25, 2022
Merged
Implement context-specific tags on #[derive(Sequence)]#349
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Conversation
@bstrie
@bstriebstrie
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
If you'd like I would be happy to add more tests to cover the interactions between the various options, but I admit that I'm not an ASN.1 expert so I would need some guidance as to how these options interact so that I could formulate the correct desugaring.
Closes#322.

This was referenced Jan 21, 2022

Closed


Closed

@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you mean context specific, not context sensitive.
@tarcieri
tarcieri
commented
Jan 21, 2022

Copy link


Copy Markdown

Member
I think you mean context specific, not context sensitive
Thanks to the Chomsky Hierarchy I have made this mistake several times myself 😅
tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/choice/variant.rs
@bstriebstrie
changed the title
Implement context-sensitive tags on #[derive(Sequence)]Implement context-specific tags on #[derive(Sequence)]Jan 21, 2022
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you need to fix the commit message wording too.
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie Also, one of the tests is failing.
@tarcieri
tarcieri
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
One of the errors is on IssuingDistributionPointsExample:
impl::der::Sequence<'_>forIssuingDistributionPointExample{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
...not sure what's happening there but the empty tuple is definitely not the right result.
Looks like something similar on the other error:
impl<'a>::der::Sequence<'a>forOneAsymmetricKey<'a>{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
Perhaps the unparseable tokens are being lost?
error: proc-macro derive produced unparseable tokens

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

@bstrie
Implement context-specific tags on #[derive(Sequence)]
b79f7ac
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@bstrie
bstrie
commented
Jan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Code updated to pass all the tests (sorry about not doing so the first time, I forgot to test with --all-features). The tests that were failing were already using context-specific tags (which I guess were just being ignored before now) in conjunction with various other field attributes. Taking into account all the supported combinations of the currently-implemented attributes was a bit tricky and required some subtle changes to make sure all the references lined up correctly, but in the end I think I managed to find a nice arrangement that doesn't involve adding state to the Lowerer or else compromising the unit-testability of the Lowerer methods. Once again I tested this with #323 to confirm that it addresses #322 .
tarcieri
tarcieri
reviewed
Jan 25, 2022
View reviewed changes
Comment threadder/tests/derive.rs

 #[derive(Sequence)]
 #[asn1(tag_mode = "IMPLICIT")]
 pub struct TypeCheckExpandedSequenceFieldAttributeCombinations<'a> {
@tarcieritarcieriJan 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 😅
@bstriebstrieJan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call that "self-documenting code". :P
@tarcieri
tarcieri
merged commit 0c416e9
into
RustCrypto:masterJan 25, 2022
npmccallum pushed a commit
to npmccallum/formats
that referenced
this pull request
Jan 27, 2022
@bstrie@npmccallum
Implement context-specific tags on #[derive(Sequence)] (RustCrypto#349)
e191b99
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@tarcieritarcieri
mentioned this pull request
May 8, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.
der crate fails to emit implicit context-specific tags on SET

3 participants

@bstrie@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Implement context-specific tags on #[derive(Sequence)] by bstrie · Pull Request #349 · RustCrypto/formats · GitHub
Skip to content
Implement context-specific tags on #[derive(Sequence)] - #349
Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Jan 25, 2022
Merged
Implement context-specific tags on #[derive(Sequence)]#349
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Conversation
@bstrie
@bstriebstrie
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
If you'd like I would be happy to add more tests to cover the interactions between the various options, but I admit that I'm not an ASN.1 expert so I would need some guidance as to how these options interact so that I could formulate the correct desugaring.
Closes#322.

This was referenced Jan 21, 2022

Closed


Closed

@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you mean context specific, not context sensitive.
@tarcieri
tarcieri
commented
Jan 21, 2022

Copy link


Copy Markdown

Member
I think you mean context specific, not context sensitive
Thanks to the Chomsky Hierarchy I have made this mistake several times myself 😅
tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/choice/variant.rs
@bstriebstrie
changed the title
Implement context-sensitive tags on #[derive(Sequence)]Implement context-specific tags on #[derive(Sequence)]Jan 21, 2022
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you need to fix the commit message wording too.
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie Also, one of the tests is failing.
@tarcieri
tarcieri
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
One of the errors is on IssuingDistributionPointsExample:
impl::der::Sequence<'_>forIssuingDistributionPointExample{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
...not sure what's happening there but the empty tuple is definitely not the right result.
Looks like something similar on the other error:
impl<'a>::der::Sequence<'a>forOneAsymmetricKey<'a>{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
Perhaps the unparseable tokens are being lost?
error: proc-macro derive produced unparseable tokens

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

@bstrie
Implement context-specific tags on #[derive(Sequence)]
b79f7ac
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@bstrie
bstrie
commented
Jan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Code updated to pass all the tests (sorry about not doing so the first time, I forgot to test with --all-features). The tests that were failing were already using context-specific tags (which I guess were just being ignored before now) in conjunction with various other field attributes. Taking into account all the supported combinations of the currently-implemented attributes was a bit tricky and required some subtle changes to make sure all the references lined up correctly, but in the end I think I managed to find a nice arrangement that doesn't involve adding state to the Lowerer or else compromising the unit-testability of the Lowerer methods. Once again I tested this with #323 to confirm that it addresses #322 .
tarcieri
tarcieri
reviewed
Jan 25, 2022
View reviewed changes
Comment threadder/tests/derive.rs

 #[derive(Sequence)]
 #[asn1(tag_mode = "IMPLICIT")]
 pub struct TypeCheckExpandedSequenceFieldAttributeCombinations<'a> {
@tarcieritarcieriJan 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 😅
@bstriebstrieJan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call that "self-documenting code". :P
@tarcieri
tarcieri
merged commit 0c416e9
into
RustCrypto:masterJan 25, 2022
npmccallum pushed a commit
to npmccallum/formats
that referenced
this pull request
Jan 27, 2022
@bstrie@npmccallum
Implement context-specific tags on #[derive(Sequence)] (RustCrypto#349)
e191b99
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@tarcieritarcieri
mentioned this pull request
May 8, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.
der crate fails to emit implicit context-specific tags on SET

3 participants

@bstrie@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Implement context-specific tags on #[derive(Sequence)] by bstrie · Pull Request #349 · RustCrypto/formats · GitHub
Skip to content
Implement context-specific tags on #[derive(Sequence)] - #349
Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Jan 25, 2022
Merged
Implement context-specific tags on #[derive(Sequence)]#349
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Conversation
@bstrie
@bstriebstrie
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
If you'd like I would be happy to add more tests to cover the interactions between the various options, but I admit that I'm not an ASN.1 expert so I would need some guidance as to how these options interact so that I could formulate the correct desugaring.
Closes#322.

This was referenced Jan 21, 2022

Closed


Closed

@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you mean context specific, not context sensitive.
@tarcieri
tarcieri
commented
Jan 21, 2022

Copy link


Copy Markdown

Member
I think you mean context specific, not context sensitive
Thanks to the Chomsky Hierarchy I have made this mistake several times myself 😅
tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/choice/variant.rs
@bstriebstrie
changed the title
Implement context-sensitive tags on #[derive(Sequence)]Implement context-specific tags on #[derive(Sequence)]Jan 21, 2022
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you need to fix the commit message wording too.
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie Also, one of the tests is failing.
@tarcieri
tarcieri
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
One of the errors is on IssuingDistributionPointsExample:
impl::der::Sequence<'_>forIssuingDistributionPointExample{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
...not sure what's happening there but the empty tuple is definitely not the right result.
Looks like something similar on the other error:
impl<'a>::der::Sequence<'a>forOneAsymmetricKey<'a>{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
Perhaps the unparseable tokens are being lost?
error: proc-macro derive produced unparseable tokens

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

@bstrie
Implement context-specific tags on #[derive(Sequence)]
b79f7ac
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@bstrie
bstrie
commented
Jan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Code updated to pass all the tests (sorry about not doing so the first time, I forgot to test with --all-features). The tests that were failing were already using context-specific tags (which I guess were just being ignored before now) in conjunction with various other field attributes. Taking into account all the supported combinations of the currently-implemented attributes was a bit tricky and required some subtle changes to make sure all the references lined up correctly, but in the end I think I managed to find a nice arrangement that doesn't involve adding state to the Lowerer or else compromising the unit-testability of the Lowerer methods. Once again I tested this with #323 to confirm that it addresses #322 .
tarcieri
tarcieri
reviewed
Jan 25, 2022
View reviewed changes
Comment threadder/tests/derive.rs

 #[derive(Sequence)]
 #[asn1(tag_mode = "IMPLICIT")]
 pub struct TypeCheckExpandedSequenceFieldAttributeCombinations<'a> {
@tarcieritarcieriJan 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 😅
@bstriebstrieJan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call that "self-documenting code". :P
@tarcieri
tarcieri
merged commit 0c416e9
into
RustCrypto:masterJan 25, 2022
npmccallum pushed a commit
to npmccallum/formats
that referenced
this pull request
Jan 27, 2022
@bstrie@npmccallum
Implement context-specific tags on #[derive(Sequence)] (RustCrypto#349)
e191b99
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@tarcieritarcieri
mentioned this pull request
May 8, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.
der crate fails to emit implicit context-specific tags on SET

3 participants

@bstrie@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Implement context-specific tags on #[derive(Sequence)] by bstrie · Pull Request #349 · RustCrypto/formats · GitHub
Skip to content
Implement context-specific tags on #[derive(Sequence)] - #349
Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Jan 25, 2022
Merged
Implement context-specific tags on #[derive(Sequence)]#349
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Conversation
@bstrie
@bstriebstrie
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
If you'd like I would be happy to add more tests to cover the interactions between the various options, but I admit that I'm not an ASN.1 expert so I would need some guidance as to how these options interact so that I could formulate the correct desugaring.
Closes#322.

This was referenced Jan 21, 2022

Closed


Closed

@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you mean context specific, not context sensitive.
@tarcieri
tarcieri
commented
Jan 21, 2022

Copy link


Copy Markdown

Member
I think you mean context specific, not context sensitive
Thanks to the Chomsky Hierarchy I have made this mistake several times myself 😅
tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/choice/variant.rs
@bstriebstrie
changed the title
Implement context-sensitive tags on #[derive(Sequence)]Implement context-specific tags on #[derive(Sequence)]Jan 21, 2022
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you need to fix the commit message wording too.
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie Also, one of the tests is failing.
@tarcieri
tarcieri
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
One of the errors is on IssuingDistributionPointsExample:
impl::der::Sequence<'_>forIssuingDistributionPointExample{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
...not sure what's happening there but the empty tuple is definitely not the right result.
Looks like something similar on the other error:
impl<'a>::der::Sequence<'a>forOneAsymmetricKey<'a>{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
Perhaps the unparseable tokens are being lost?
error: proc-macro derive produced unparseable tokens

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

@bstrie
Implement context-specific tags on #[derive(Sequence)]
b79f7ac
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@bstrie
bstrie
commented
Jan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Code updated to pass all the tests (sorry about not doing so the first time, I forgot to test with --all-features). The tests that were failing were already using context-specific tags (which I guess were just being ignored before now) in conjunction with various other field attributes. Taking into account all the supported combinations of the currently-implemented attributes was a bit tricky and required some subtle changes to make sure all the references lined up correctly, but in the end I think I managed to find a nice arrangement that doesn't involve adding state to the Lowerer or else compromising the unit-testability of the Lowerer methods. Once again I tested this with #323 to confirm that it addresses #322 .
tarcieri
tarcieri
reviewed
Jan 25, 2022
View reviewed changes
Comment threadder/tests/derive.rs

 #[derive(Sequence)]
 #[asn1(tag_mode = "IMPLICIT")]
 pub struct TypeCheckExpandedSequenceFieldAttributeCombinations<'a> {
@tarcieritarcieriJan 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 😅
@bstriebstrieJan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call that "self-documenting code". :P
@tarcieri
tarcieri
merged commit 0c416e9
into
RustCrypto:masterJan 25, 2022
npmccallum pushed a commit
to npmccallum/formats
that referenced
this pull request
Jan 27, 2022
@bstrie@npmccallum
Implement context-specific tags on #[derive(Sequence)] (RustCrypto#349)
e191b99
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@tarcieritarcieri
mentioned this pull request
May 8, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.
der crate fails to emit implicit context-specific tags on SET

3 participants

@bstrie@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Implement context-specific tags on #[derive(Sequence)] by bstrie · Pull Request #349 · RustCrypto/formats · GitHub
Skip to content
Implement context-specific tags on #[derive(Sequence)] - #349
Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Jan 25, 2022
Merged
Implement context-specific tags on #[derive(Sequence)]#349
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Conversation
@bstrie
@bstriebstrie
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
If you'd like I would be happy to add more tests to cover the interactions between the various options, but I admit that I'm not an ASN.1 expert so I would need some guidance as to how these options interact so that I could formulate the correct desugaring.
Closes#322.

This was referenced Jan 21, 2022

Closed


Closed

@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you mean context specific, not context sensitive.
@tarcieri
tarcieri
commented
Jan 21, 2022

Copy link


Copy Markdown

Member
I think you mean context specific, not context sensitive
Thanks to the Chomsky Hierarchy I have made this mistake several times myself 😅
tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/choice/variant.rs
@bstriebstrie
changed the title
Implement context-sensitive tags on #[derive(Sequence)]Implement context-specific tags on #[derive(Sequence)]Jan 21, 2022
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you need to fix the commit message wording too.
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie Also, one of the tests is failing.
@tarcieri
tarcieri
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
One of the errors is on IssuingDistributionPointsExample:
impl::der::Sequence<'_>forIssuingDistributionPointExample{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
...not sure what's happening there but the empty tuple is definitely not the right result.
Looks like something similar on the other error:
impl<'a>::der::Sequence<'a>forOneAsymmetricKey<'a>{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
Perhaps the unparseable tokens are being lost?
error: proc-macro derive produced unparseable tokens

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

@bstrie
Implement context-specific tags on #[derive(Sequence)]
b79f7ac
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@bstrie
bstrie
commented
Jan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Code updated to pass all the tests (sorry about not doing so the first time, I forgot to test with --all-features). The tests that were failing were already using context-specific tags (which I guess were just being ignored before now) in conjunction with various other field attributes. Taking into account all the supported combinations of the currently-implemented attributes was a bit tricky and required some subtle changes to make sure all the references lined up correctly, but in the end I think I managed to find a nice arrangement that doesn't involve adding state to the Lowerer or else compromising the unit-testability of the Lowerer methods. Once again I tested this with #323 to confirm that it addresses #322 .
tarcieri
tarcieri
reviewed
Jan 25, 2022
View reviewed changes
Comment threadder/tests/derive.rs

 #[derive(Sequence)]
 #[asn1(tag_mode = "IMPLICIT")]
 pub struct TypeCheckExpandedSequenceFieldAttributeCombinations<'a> {
@tarcieritarcieriJan 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 😅
@bstriebstrieJan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call that "self-documenting code". :P
@tarcieri
tarcieri
merged commit 0c416e9
into
RustCrypto:masterJan 25, 2022
npmccallum pushed a commit
to npmccallum/formats
that referenced
this pull request
Jan 27, 2022
@bstrie@npmccallum
Implement context-specific tags on #[derive(Sequence)] (RustCrypto#349)
e191b99
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@tarcieritarcieri
mentioned this pull request
May 8, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.
der crate fails to emit implicit context-specific tags on SET

3 participants

@bstrie@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Implement context-specific tags on #[derive(Sequence)] by bstrie · Pull Request #349 · RustCrypto/formats · GitHub
Skip to content
Implement context-specific tags on #[derive(Sequence)] - #349
Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Jan 25, 2022
Merged
Implement context-specific tags on #[derive(Sequence)]#349
tarcieri merged 1 commit into
RustCrypto:masterfrom 
bstrie:implicitseqder
Conversation
@bstrie
@bstriebstrie
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
If you'd like I would be happy to add more tests to cover the interactions between the various options, but I admit that I'm not an ASN.1 expert so I would need some guidance as to how these options interact so that I could formulate the correct desugaring.
Closes#322.

This was referenced Jan 21, 2022

Closed


Closed

@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you mean context specific, not context sensitive.
@tarcieri
tarcieri
commented
Jan 21, 2022

Copy link


Copy Markdown

Member
I think you mean context specific, not context sensitive
Thanks to the Chomsky Hierarchy I have made this mistake several times myself 😅
tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/choice/variant.rs
@bstriebstrie
changed the title
Implement context-sensitive tags on #[derive(Sequence)]Implement context-specific tags on #[derive(Sequence)]Jan 21, 2022
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie I think you need to fix the commit message wording too.
@npmccallum
npmccallum
commented
Jan 21, 2022

Copy link


Copy Markdown

Contributor
@bstrie Also, one of the tests is failing.
@tarcieri
tarcieri
commented
Jan 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
One of the errors is on IssuingDistributionPointsExample:
impl::der::Sequence<'_>forIssuingDistributionPointExample{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
...not sure what's happening there but the empty tuple is definitely not the right result.
Looks like something similar on the other error:
impl<'a>::der::Sequence<'a>forOneAsymmetricKey<'a>{fnfields<F,T>(&self,f:F) -> ::der::Result<T>whereF:FnOnce(&[&dyn der::Encodable]) -> ::der::Result<T>,{()}}
Perhaps the unparseable tokens are being lost?
error: proc-macro derive produced unparseable tokens

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

tarcieri
tarcieri
reviewed
Jan 21, 2022
View reviewed changes
Comment threadder/derive/src/sequence/field.rs
Outdated

@bstrie
Implement context-specific tags on #[derive(Sequence)]
b79f7ac
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@bstrie
bstrie
commented
Jan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Code updated to pass all the tests (sorry about not doing so the first time, I forgot to test with --all-features). The tests that were failing were already using context-specific tags (which I guess were just being ignored before now) in conjunction with various other field attributes. Taking into account all the supported combinations of the currently-implemented attributes was a bit tricky and required some subtle changes to make sure all the references lined up correctly, but in the end I think I managed to find a nice arrangement that doesn't involve adding state to the Lowerer or else compromising the unit-testability of the Lowerer methods. Once again I tested this with #323 to confirm that it addresses #322 .
tarcieri
tarcieri
reviewed
Jan 25, 2022
View reviewed changes
Comment threadder/tests/derive.rs

 #[derive(Sequence)]
 #[asn1(tag_mode = "IMPLICIT")]
 pub struct TypeCheckExpandedSequenceFieldAttributeCombinations<'a> {
@tarcieritarcieriJan 25, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 😅
@bstriebstrieJan 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call that "self-documenting code". :P
@tarcieri
tarcieri
merged commit 0c416e9
into
RustCrypto:masterJan 25, 2022
npmccallum pushed a commit
to npmccallum/formats
that referenced
this pull request
Jan 27, 2022
@bstrie@npmccallum
Implement context-specific tags on #[derive(Sequence)] (RustCrypto#349)
e191b99
This also adds a context-specific tag test to the code for #[derive(Choice)], and cleans up the tests in these files.
@tarcieritarcieri
mentioned this pull request
May 8, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.
der crate fails to emit implicit context-specific tags on SET

3 participants

@bstrie@npmccallum@tarcieri