') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix length calculation for explicit tags by npmccallum · Pull Request #400 · RustCrypto/formats · GitHub
Skip to content

Fix length calculation for explicit tags - #400

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
npmccallum:der
Feb 8, 2022
Merged

Fix length calculation for explicit tags#400
tarcieri merged 1 commit into
RustCrypto:masterfrom
npmccallum:der

Conversation

@npmccallum

@npmccallumnpmccallum commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

When deriving Choice, the existing macros emit incorrect length
calculation code when explicit tags are used.

Signed-off-by: Nathaniel McCallum nathaniel@profian.com

@npmccallum
Fix length calculation for explicit tags
9d0e7f0
When deriving `Choice`, the existing macros emit incorrect length
calculation code when explicit tags are used.
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@tarcieri

tarcieri commented Feb 8, 2022

Copy link
Copy Markdown
Member

Nice! Can you add a test for the code generated for an EXPLICIT context-specific field?

@npmccallum

npmccallum commented Feb 8, 2022

Copy link
Copy Markdown
ContributorAuthor

@tarcieri Is it sufficient to convert GeneralName to a derive with all tests passing? Because that's the real test case driving these fixes.

@tarcieri

tarcieri commented Feb 8, 2022

Copy link
Copy Markdown
Member

@npmccallum that's probably fine for now. I can circle back and add some tests

@tarcieri
tarcieri merged commit 98cabaa into RustCrypto:masterFeb 8, 2022
@carl-wallace

carl-wallace commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

I can run in builder/validator against PKITS, FPKI and Web PKI certs when there's a chance to update. That hits a fair number of extensions that ought exercise the moving parts.

@tarcieri

tarcieri commented Feb 8, 2022

Copy link
Copy Markdown
Member

I'm really more worried about custom derive unit tests which test the output against some expected generated code.

The reason why they're important is debugging lowering failures outside of unit tests is a huge headache.

@carl-wallace

carl-wallace commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

Sure, but catching errors from a broad set of data can inform adding unit tests. Many of the tests there are from cases that failed and highlighted an issue. But given much of what is moving is addressing compilation errors, it probably matters less. Will hold off.

@tarcieritarcieri mentioned this pull request May 8, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@npmccallum@tarcieri@carl-wallace