Uh oh!
There was an error while loading. Please reload this page.
x509-cert: make Certificate an owned type - #806
Merged
Conversation
balooforce-pushed
the
baloo/owned-api/certificate
branch
from
December 18, 2022 18:16
ba1164d to
c1c0d47CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
balooforce-pushed
the
baloo/owned-api/certificate
branch
5 times, most recently
from
December 19, 2022 03:51
a215178 to
1188fcfComparetarcieri
commented
Dec 30, 2022
Member
@baloo can you rebase? |
balooforce-pushed
the
baloo/owned-api/certificate
branch
from
December 30, 2022 04:26
1188fcf to
f41a358Comparebaloo
commented
Dec 30, 2022
MemberAuthor
@tarcieri done |
balooforce-pushed
the
baloo/owned-api/certificate
branch
from
December 30, 2022 04:43
81c741d to
2109a1bComparetarcieri
commented
Dec 30, 2022
Member
Thank you! |
npmccallum added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
npmccallum added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
npmccallum added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
npmccallum added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
npmccallum added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri pushed a commit
that referenced
this pull request
Jan 10, 2023
#806 The above PR made most types in this crate owned. However, some types were missed. For consistency, complete the migration. Removed alloc feature: this crate unconditionally requires alloc. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
This was referenced Mar 19, 2023
Merged
Closed
scv35 pushed a commit
to scv35/format-encoders-decoders
that referenced
this pull request
Jul 4, 2025
RustCrypto/formats#806 The above PR made most types in this crate owned. However, some types were missed. For consistency, complete the migration. Removed alloc feature: this crate unconditionally requires alloc. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
ghost-knightx56yui added a commit
to ghost-knightx56yui/formats
that referenced
this pull request
Nov 13, 2025
RustCrypto/formats#806 The above PR made most types in this crate owned. However, some types were missed. For consistency, complete the migration. Removed alloc feature: this crate unconditionally requires alloc. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #803 let's make
Certificatean owned type. We'll revisit that in a follow up PR to accept atrait Profileas parameter allowing it to be either a reference or an owned type.