') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); der: missing impl TryFrom<AnyRef> by baloo · Pull Request #834 · RustCrypto/formats · GitHub
Skip to content

der: missing impl TryFrom<AnyRef> - #834

Merged
tarcieri merged 3 commits into
RustCrypto:masterfrom
baloo:baloo/owned-api/missing-tryfrom
Jan 4, 2023
Merged

der: missing impl TryFrom<AnyRef>#834
tarcieri merged 3 commits into
RustCrypto:masterfrom
baloo:baloo/owned-api/missing-tryfrom

Conversation

@baloo

@baloobaloo commented Jan 3, 2023

Copy link
Copy Markdown
Member

This removes some duplication but most importantly adds the missing implementations.

@baloobaloo changed the title der: impl TryFrom<AnyRef> in the string macroder: missing impl TryFrom<AnyRef>Jan 3, 2023
baloo
baloo commented Jan 3, 2023
View reviewed changes
Comment threadder/src/asn1/internal_macros.rs
@@ -1,17 +1,47 @@
macro_rules! impl_string_type {
macro_rules! impl_type {

@baloobalooJan 3, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I splitted it as I think I can just reuse this in BitString, GeneralizedTime, Int*, OctetString and UtcTime

@baloo
balooforce-pushed the baloo/owned-api/missing-tryfrom branch 2 times, most recently from 697ba62 to b822b68CompareJanuary 3, 2023 03:48
@baloo
balooforce-pushed the baloo/owned-api/missing-tryfrom branch from b822b68 to 32fcd62CompareJanuary 3, 2023 18:16
tarcieri
tarcieri approved these changes Jan 4, 2023
View reviewed changes

@tarcieritarcieri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice refactor, albeit a bit hard to review.

If you're happy with this I can merge.

@baloo

baloo commented Jan 4, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Yeah, there is some noise. It's slightly easier with whitespace removed.
https://github.com/RustCrypto/formats/pull/834/files?w=1

I don't have much to add, this was mostly shuffling stuff around.

@tarcieri
tarcieri merged commit eab27ea into RustCrypto:masterJan 4, 2023
@baloo
baloo deleted the baloo/owned-api/missing-tryfrom branch January 4, 2023 19:40
@woodruffwwoodruffw mentioned this pull request Jan 20, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baloo@tarcieri