Uh oh!
There was an error while loading. Please reload this page.
pkcs7: make types for creating messages public - #991
Merged
Conversation
bkstein
marked this pull request as draft
April 6, 2023 18:35
bkstein
commented
Apr 6, 2023
ContributorAuthor
Oh oh, looks like I activated std. I'll check that. |
tarcieri
reviewed
Apr 6, 2023
Uh oh!
There was an error while loading. Please reload this page.
bkstein
marked this pull request as ready for review
April 8, 2023 11:35
tarcieri
reviewed
Apr 9, 2023
Uh oh!
There was an error while loading. Please reload this page.
tarcieri
commented
Apr 9, 2023
Member
Looks good overall. One nit about what seems like it was leftover debugging code. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal (say: a trial ballon) for how PKSC #7 messages could be created. The work is not done with this request. Signing and encryption is missing, but by making some types public, we can at least get a PKSC #7 scaffolding with certificates.
Is this a good way? Should I proceed with it? Or do you already have other plans?