Skip to content

Implement SerializableState for hashes - #574

Merged
tarcieri merged 19 commits into
RustCrypto:masterfrom
baloo:baloo/serialize-state/rebase
Mar 19, 2024
Merged

Implement SerializableState for hashes#574
tarcieri merged 19 commits into
RustCrypto:masterfrom
baloo:baloo/serialize-state/rebase

Conversation

@baloo

@baloobaloo commented Mar 17, 2024

Copy link
Copy Markdown
Member

This is a rebase of #385 on master.

RustCrypto/traits#1369 introduced a SerializableState trait to serialize the hasher. This implements it for each of the hashers we have.

This depends on:

@baloo

baloo commented Mar 17, 2024

Copy link
Copy Markdown
MemberAuthor

cc @rpiasetskyi

Edit: The github UI is a bit confusing. I tried my best to keep your authorship, and I think individual commits should reflect that, but the github UI only lists me.

@baloo
balooforce-pushed the baloo/serialize-state/rebase branch 2 times, most recently from ab24678 to 375bdc1CompareMarch 17, 2024 05:56
@baloo
balooforce-pushed the baloo/serialize-state/rebase branch from 375bdc1 to fce1d94CompareMarch 18, 2024 03:13
Comment threadfsb/src/macros.rs Outdated
@baloo
balooforce-pushed the baloo/serialize-state/rebase branch from 6f1cd19 to a31cc1fCompareMarch 18, 2024 03:41
@wiktor-k

Copy link
Copy Markdown

This PR solves the issue with using SerializableState in my project that I've reported in RustCrypto/traits#1369 (comment)

Thanks for your work @baloo 🙏 !

@baloo
balooforce-pushed the baloo/serialize-state/rebase branch from a31cc1f to e7f742bCompareMarch 18, 2024 22:27
@tarcieri
tarcieri merged commit c30e701 into RustCrypto:masterMar 19, 2024
@baloo
baloo deleted the baloo/serialize-state/rebase branch March 19, 2024 21:48
@tarcieritarcieri mentioned this pull request Feb 18, 2026
27 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@baloo@wiktor-k@tarcieri