Skip to content

Add support for Persona and Salt to Blake2 - #78

Merged
tarcieri merged 4 commits into
RustCrypto:masterfrom
str4d:blake2-params
May 25, 2020
Merged

Add support for Persona and Salt to Blake2#78
tarcieri merged 4 commits into
RustCrypto:masterfrom
str4d:blake2-params

Conversation

@str4d

@str4dstr4d commented Apr 11, 2019

Copy link
Copy Markdown
Contributor

Closes#75.

@str4d

str4d commented Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

This PR is ported from cesarb/blake2-rfc#9

@burdges

burdges commented Apr 11, 2019

Copy link
Copy Markdown

I'd think the byteorder crate is kinda deprecated by std::u32/u64::to_le_bytes/from_le_bytes, etc. now.

@str4d

str4d commented Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Neat, I hadn't spotted those! However, using them would raise the minimum-supported Rust version to 1.32, while it is currently 1.21.

@str4dstr4d mentioned this pull request Apr 11, 2019
Closed
@str4dstr4d mentioned this pull request Apr 30, 2019
Closed
@str4d

str4d commented Apr 30, 2019

Copy link
Copy Markdown
ContributorAuthor

@newpavlov do you have any feedback on this PR? Based on #75 (comment) I assumed that you'd be happy with a direct port of the blake2-rfc PR.

@str4d

str4d commented Jun 4, 2019

Copy link
Copy Markdown
ContributorAuthor

To anyone else looking for personalisation, the blake2b_simd and blake2s_simd crates have personalisation APIs. They also mandate the use of SIMD when available however, so I think it's still valuable to have this PR merged for those projects that don't want a SIMD dependency.

tarcieri
tarcieri reviewed Jun 4, 2019
View reviewed changes
Comment threadblake2/Cargo.toml
@tarcieri

tarcieri commented May 24, 2020

Copy link
Copy Markdown
Member

@str4d still interested in this, and if so, mind rebasing?

@str4d

str4d commented May 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Rebased on current master.

@tarcieri
tarcieri merged commit 41b7437 into RustCrypto:masterMay 25, 2020
@tarcieritarcieri mentioned this pull request Jun 10, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Persona and Salt to Blake2

4 participants

@str4d@burdges@tarcieri@gtank