Uh oh!
There was an error while loading. Please reload this page.
Small code improvements - #94
Merged
Merged
Conversation
| #![cfg_attr(feature = "cargo-clippy", allow(clippy::needless_range_loop, clippy::inline_always))] | ||
| use digest::{Input, BlockInput, FixedOutput, Reset}; | ||
| use digest::generic_array::typenum::{Unsigned, U64}; | ||
| use digest::generic_array::typenum::U64; |
Member
There was a problem hiding this comment.
The build fails because you've removed Unsigned here, I am not sure why it happens, but until we bump MSRV lets keep it as-is.
ContributorAuthor
There was a problem hiding this comment.
You're right.
I've fixed it.
rodoufu
commented
Jan 31, 2020
ContributorAuthor
@newpavlov at first I was making a change but some time after I realized that it wasn't necessary. |
rodoufu
commented
May 14, 2020
ContributorAuthor
@newpavlov do you still intend to review it? |
tarcieri
commented
May 15, 2020
Member
Thanks! |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build is failing due to a problem on
streebog.rs:149but I haven't changed that.