Uh oh!
There was an error while loading. Please reload this page.
Add helper functions for Array<MaybeUninit<T>, U> - #8
Merged
Conversation
Adds the following functions: - `uninit`: construct an uninitialized `Array<MaybeUninit<T>, U>` - `assume_init`: converts to `Array<T, U>` assuming all elements are initialized
tarcieriforce-pushed
the
maybe-uninit-helpers
branch
from
January 11, 2024 19:42
6738323 to
1582c18Comparetarcieri
commented
Jan 11, 2024
Uh oh!
There was an error while loading. Please reload this page.
newpavlov
approved these changes
Jan 11, 2024
tarcieri
commented
Jan 11, 2024
MemberAuthor
Expanding the safety comment sounds good. I can also add a link to the similarly-shaped |
This makes the bounds more complicated but makes it much clearer what's happening, as before it was relying on an implicit definition of `ArraySize::ArrayType`.
tarcieri
commented
Jan 11, 2024
MemberAuthor
@newpavlovd7f32a4 should make it much more explicit what's happening (at the cost of slightly more complicated bounds), and also clears the clippy warning |
tarcieri
commented
Jan 11, 2024
MemberAuthor
Seems at little closer to |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following functions:
uninit: construct an uninitializedArray<MaybeUninit<T>, U>assume_init: converts toArray<T, U>assuming all elements are initialized