') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); pbkdf2: make public PBKDF2 Ident values by ChanTsune · Pull Request #375 · RustCrypto/password-hashes · GitHub
Skip to content

pbkdf2: make public PBKDF2 Ident values - #375

Merged
tarcieri merged 3 commits into
RustCrypto:masterfrom
ChanTsune:pbkdf2
Feb 17, 2023
Merged

pbkdf2: make public PBKDF2 Ident values#375
tarcieri merged 3 commits into
RustCrypto:masterfrom
ChanTsune:pbkdf2

Conversation

@ChanTsune

@ChanTsuneChanTsune commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

For RustCrypto members

Thank you for developing a awesome crate!

I have a question.

Why do the other crates maintained by this repository have published Ident values, but not in pbkdf2?

Looking at the code, it seems that there is an intention to publish it, but it is not available because there is no use declaration.

If you just forgot to publish it, I would appreciate it if you could merge this PR and make it available.

@tarcieri

tarcieri commented Feb 15, 2023

Copy link
Copy Markdown
Member

Before exporting these I think we might consider better names that reflect they're Idents.

Perhaps either adding *_IDENT to their names or making them inherent constants like Pbkdf2::SHA256_IDENT.

@ChanTsune

ChanTsune commented Feb 16, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thanks for your advice!
I added _IDENT as a suffix to each.

@tarcieri

tarcieri commented Feb 16, 2023

Copy link
Copy Markdown
Member

Personally I think I'd prefer the inherent constant approach, since it cuts down on the number of exports/imports

@ChanTsune

ChanTsune commented Feb 17, 2023

Copy link
Copy Markdown
ContributorAuthor

OK!, so how about making it an intrinsic constant of Algorithm following the other crates as follows?

https://github.com/ChanTsune/password-hashes/blob/ca2ff2abdfa347ce7d6a3e4bd764f988ba9a282c/pbkdf2/src/simple.rs#L82-L94

@tarcieri

tarcieri commented Feb 17, 2023

Copy link
Copy Markdown
Member

That looks good, yes

tarcieri
tarcieri approved these changes Feb 17, 2023
View reviewed changes

@tarcieritarcieri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tarcieri
tarcieri merged commit 86bdad3 into RustCrypto:masterFeb 17, 2023
@ChanTsune
ChanTsune deleted the pbkdf2 branch February 17, 2023 23:24
@tarcieritarcieri mentioned this pull request Mar 5, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChanTsune@tarcieri