') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); ecdsa: add hazmat::RecoverableSignPrimitive by tarcieri · Pull Request #111 · RustCrypto/signatures · GitHub
Skip to content

ecdsa: add hazmat::RecoverableSignPrimitive - #111

Merged
tarcieri merged 1 commit into
masterfrom
ecdsa/recoverable-sign-primitive
Aug 4, 2020
Merged

ecdsa: add hazmat::RecoverableSignPrimitive#111
tarcieri merged 1 commit into
masterfrom
ecdsa/recoverable-sign-primitive

Conversation

@tarcieri

@tarcieritarcieri commented Aug 4, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Trait for signature algorithm implementations that support public key recovery, with a blanket impl for SignPrimitive.

@tarcieri
ecdsa: add hazmat::RecoverableSignPrimitive
d78de45
Trait for signature algorithm implementations that support public key
recovery, with a blanket impl for SignPrimitive.
@codecov-commenter

codecov-commenter commented Aug 4, 2020•
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.97%. Comparing base (9cba7df) to head (d78de45).
Report is 793 commits behind head on master.

Files with missing linesPatch %Lines
ecdsa/src/hazmat.rs0.00%3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## master #111 +/- ##
==========================================
- Coverage 46.63% 45.97% -0.67% 
==========================================
Files 5 6 +1 Lines 208 211 +3 ==========================================
Hits 97 97 - Misses 111 114 +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tarcieri
tarcieri merged commit 4124ce3 into masterAug 4, 2020
@tarcieri
tarcieri deleted the ecdsa/recoverable-sign-primitive branch August 4, 2020 03:23
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 4, 2020
@tarcieri
k256: impl ecdsa::hazmat::RecoverableSignPrimitive
0736852
Impls the `RecoverableSignPrimitive` trait introduced in
RustCrypto/signatures#111 which returns the necessary information
(even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to
compute the recovery ID without using brute force trial recovery.
This implementation leaks some details the existing `ecdsa` crate APIs
are trying to abstract over, but hopefully can feed into the
requirements for what those APIs should actually look like.
@tarcieritarcieri mentioned this pull request Aug 4, 2020
Merged
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 4, 2020
@tarcieri
k256: impl ecdsa::hazmat::RecoverableSignPrimitive
468ea8c
Impls the `RecoverableSignPrimitive` trait introduced in
RustCrypto/signatures#111 which returns the necessary information
(even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to
compute the recovery ID without using brute force trial recovery.
This implementation leaks some details the existing `ecdsa` crate APIs
are trying to abstract over, but hopefully can feed into the
requirements for what those APIs should actually look like.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 4, 2020
@tarcieri
k256: impl ecdsa::hazmat::RecoverableSignPrimitive
564675e
Impls the `RecoverableSignPrimitive` trait introduced in
RustCrypto/signatures#111 which returns the necessary information
(even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to
compute the recovery ID without using brute force trial recovery.
This implementation leaks some details the existing `ecdsa` crate APIs
are trying to abstract over, but hopefully can feed into the
requirements for what those APIs should actually look like.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 4, 2020
@tarcieri
k256: impl ecdsa::hazmat::RecoverableSignPrimitive
51fd051
Impls the `RecoverableSignPrimitive` trait introduced in
RustCrypto/signatures#111 which returns the necessary information
(even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to
compute the recovery ID without using brute force trial recovery.
This implementation leaks some details the existing `ecdsa` crate APIs
are trying to abstract over, but hopefully can feed into the
requirements for what those APIs should actually look like.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 4, 2020
@tarcieri
k256: impl ecdsa::hazmat::RecoverableSignPrimitive (#111)
109e7ab
Impls the `RecoverableSignPrimitive` trait introduced in
RustCrypto/signatures#111 which returns the necessary information
(even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to
compute the recovery ID without using brute force trial recovery.
This implementation leaks some details the existing `ecdsa` crate APIs
are trying to abstract over, but hopefully can feed into the
requirements for what those APIs should actually look like.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 4, 2020
@tarcieri
k256: impl ecdsa::hazmat::RecoverableSignPrimitive
e64b529
Impls the `RecoverableSignPrimitive` trait introduced in
RustCrypto/signatures#111 which returns the necessary information
(even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to
compute the recovery ID without using brute force trial recovery.
This implementation leaks some details the existing `ecdsa` crate APIs
are trying to abstract over, but hopefully can feed into the
requirements for what those APIs should actually look like.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 4, 2020
@tarcieri
k256: impl ecdsa::hazmat::RecoverableSignPrimitive
0b410a7
Impls the `RecoverableSignPrimitive` trait introduced in
RustCrypto/signatures#111 which returns the necessary information
(even-or-odd) about the ECDSA signature's `R` y-coordinate to be able to
compute the recovery ID without using brute force trial recovery.
This implementation leaks some details the existing `ecdsa` crate APIs
are trying to abstract over, but hopefully can feed into the
requirements for what those APIs should actually look like.
@tarcieritarcieri mentioned this pull request Aug 11, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarcieri@codecov-commenter