') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); ecdsa: add associated sig type to RecoverableSignPrimitive by tarcieri · Pull Request #120 · RustCrypto/signatures · GitHub
Skip to content

ecdsa: add associated sig type to RecoverableSignPrimitive - #120

Merged
tarcieri merged 1 commit into
masterfrom
ecdsa/associated-recoverable-signature-type
Aug 7, 2020
Merged

ecdsa: add associated sig type to RecoverableSignPrimitive#120
tarcieri merged 1 commit into
masterfrom
ecdsa/associated-recoverable-signature-type

Conversation

@tarcieri

@tarcieritarcieri commented Aug 7, 2020

Copy link
Copy Markdown
Member

Adds an associated RecoverableSignature type to RecoverableSignPrimitive.

This allows the primitive to handle construction of the full signature, which makes it possible to add normalization at the generic ecdsa::signer::Signer level.

@tarcieri
ecdsa: add associated sig type to RecoverableSignPrimitive
46b0202
Adds an associated `RecoverableSignature` type to
`RecoverableSignPrimitive`.
This allows the primitive to handle construction of the full signature,
which makes it possible to add normalization at the generic
`ecdsa::signer::Signer` level.
@codecov-commenter

codecov-commenter commented Aug 7, 2020

Copy link
Copy Markdown

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #120 +/- ##
=======================================
Coverage 44.29% 44.29% =======================================
Files 6 6 Lines 219 219 =======================================
Hits 97 97 Misses 122 122
Impacted FilesCoverage Δ
ecdsa/src/hazmat.rs0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8ca65...46b0202. Read the comment docs.

@tarcieritarcieri mentioned this pull request Aug 7, 2020
Closed
@tarcieri
tarcieri merged commit 5bd9671 into masterAug 7, 2020
@tarcieri
tarcieri deleted the ecdsa/associated-recoverable-signature-type branch August 7, 2020 20:26
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 7, 2020
@tarcieri
k256: impl new RecoverableSignPrimitive API
322c5d8
Implements the changes made in RustCrypto/signatures#120.
These changes have the `k256` always compute a `recoverable::Signature`
via `RecoverableSignPrimitive` and use the blanket impl of
`SignPrimitive` for `RecoverableSignPrimitive` to convert it to a
regular `k256::ecdsa::Signature` in `ecdsa::signer::Signer<Secp256k1>`.
Ideally the `k256::ecdsa::Signer` newtype could go away and this could
all be handled by `ecdsa::signer::Signer` via blanket and conditional
impls, however I'm not sure how to prevent the impls of
`RandomizedSigner` from overlapping in a generic context.
@tarcieritarcieri mentioned this pull request Aug 7, 2020
Merged
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 7, 2020
@tarcieri
k256: impl new RecoverableSignPrimitive API (#123)
86845cf
Implements the changes made in RustCrypto/signatures#120.
These changes have the `k256` always compute a `recoverable::Signature`
via `RecoverableSignPrimitive` and use the blanket impl of
`SignPrimitive` for `RecoverableSignPrimitive` to convert it to a
regular `k256::ecdsa::Signature` in `ecdsa::signer::Signer<Secp256k1>`.
Ideally the `k256::ecdsa::Signer` newtype could go away and this could
all be handled by `ecdsa::signer::Signer` via blanket and conditional
impls, however I'm not sure how to prevent the impls of
`RandomizedSigner` from overlapping in a generic context.
@tarcieritarcieri mentioned this pull request Aug 11, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarcieri@codecov-commenter