Uh oh!
There was an error while loading. Please reload this page.
ecdsa: follow the DynAssociatedAlgorithmIdentifier changes - #695
Merged
Conversation
lumag
commented
Apr 4, 2023
ContributorAuthor
I can not reproduce the build failure locally. Probably a git revision got cached somewhere and is not updated. |
tarcieri
commented
Apr 4, 2023
Member
You need to run |
lumag
commented
Apr 4, 2023
ContributorAuthor
@tarcieri local build works, it's the CI which shows an error. |
tarcieri
commented
Apr 4, 2023
Member
Is it possible you're not checking in You didn't update it in this PR, so I would expect it to fail because you're using an out-of-date version |
lumagforce-pushed
the
kai
branch
2 times, most recently
from
April 4, 2023 23:06
c517fca to
7518d24Comparetarcieri
reviewed
Apr 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
tarcieri
reviewed
Apr 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
added 2 commits
April 5, 2023 02:56
Return Result from algorithm_identifier(). Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Now as spki and der were released, drop overrides. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
tarcieri
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return Result from algorithm_identifier().
Depends on RustCrypto/formats#974