Uh oh!
There was an error while loading. Please reload this page.
Add UseDigestTo* marker trait and blanket Sign/Verify impls - #9
Closed
tarcieri wants to merge 2 commits into
Closed
Conversation
This commit makes the digest for `SignDigest` and `VerifyDigest` an associated type rather than a generic, and also adds two marker traits: - `UseDigestToSign`: opt into blanket impl of `Sign` for `SignDigest` - `UseDigestToVerify`: opt into blanket impl of `Verify` for `VerifyDigest` The reason for requiring a marker trait is there are cases where the same keys can be used with an IUF mode of an algorithm which is distinct from the non-IUF form, e.g. Ed25519 vs Ed25519ph. In this case, the underlying keys are the same, but the signature algorithm when using the IUF mode is distinct.
tarcieriforce-pushed
the
use-digest-marker-traits
branch
from
March 26, 2019 17:49
0b1b200 to
80f518aCompareMemberAuthor
One drawback of this approach is it means To preserve that, one option is to move the associated type to the marker trait (we need an associated type somewhere to constrain the blanket impl). It feels a bit redundant, but I'll go ahead and try that and push a second commit so we can compare. (Edit: did this in 2bff7eb) |
This allows the `SignDigest` and `VerifyDigest` traits to remain object safe with the same general shape as `Sign` and `Verify`.
tarcieriforce-pushed
the
use-digest-marker-traits
branch
from
March 26, 2019 18:06
2bff7eb to
0232b07Comparetarcieri
commented
Mar 26, 2019
MemberAuthor
@newpavlov I have a new idea about how to do this which I think is a little more in the middle between our approaches and better describes the underlying concepts. Will open as a new PR. |
This was referenced Mar 29, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the digest for
SignDigestandVerifyDigestan associated type rather than a generic, and also adds two marker traits:UseDigestToSign: opt into blanket impl ofSignforSignDigestUseDigestToVerify: opt into blanket impl ofVerifyforVerifyDigestThe reason for requiring a marker trait is there are cases where the same keys can be used with an IUF mode of an algorithm which is distinct from the non-IUF form, e.g. Ed25519 vs Ed25519ph. In this case, the underlying keys are the same, but the signature algorithm when using the
IUF mode is distinct.