Uh oh!
There was an error while loading. Please reload this page.
chacha20: adopt the new Generator API from rand_core - #491
Merged
Conversation
MemberAuthor
upstream PR that introduces the generator API: rust-random/rand_core#26 I've tried to adjust the upstream API to see if I could bring back the support for Zeroize, but all I ended up with was essentially a straight revert of the API. |
dhardy
reviewed
Dec 9, 2025
Uh oh!
There was an error while loading. Please reload this page.
baloo
marked this pull request as draft
December 9, 2025 19:45
balooforce-pushed
the
baloo/push-sxqszypxlxnt
branch
from
December 9, 2025 19:48
f57179d to
01043e2Comparebaloo
marked this pull request as ready for review
December 11, 2025 03:24
balooforce-pushed
the
baloo/push-sxqszypxlxnt
branch
2 times, most recently
from
December 11, 2025 03:26
8dd5dfd to
078bf89Comparebalooforce-pushed
the
baloo/push-sxqszypxlxnt
branch
from
December 17, 2025 19:01
078bf89 to
89a1551CompareContributor
Can you update this to use https://crates.io/crates/rand_core/0.10.0-rc-3 please? |
The new API force the output to be a straight array, but there is a custom drop implementation where we can put the Zeroize of the output. This bumps the `rand_core` dependency to `0.10.0-rc-3`
balooforce-pushed
the
baloo/push-sxqszypxlxnt
branch
from
December 23, 2025 00:10
89a1551 to
7c8c770Comparenewpavlov
approved these changes
Dec 23, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new API force the output to be a straight array, but there is a
custom drop implementation where we can put the Zeroize of the output.
This bumps the
rand_coredependency to0.10.0-rc-3