Uh oh!
There was an error while loading. Please reload this page.
chacha20: clippy config - #526
Merged
Merged
Conversation
tarcieri
commented
Feb 5, 2026
| /// | ||
| /// The arrays should be in little endian order. | ||
| #[derive(Clone, Copy, Debug)] | ||
| pub struct StreamId([u32; Self::LEN]); |
MemberAuthor
There was a problem hiding this comment.
Sidebar: this struct definition seems like a rather roundabout way of saying StreamId(u32, u32)
tarcieriforce-pushed
the
chacha20/clippy-config
branch
2 times, most recently
from
February 5, 2026 03:09
f603293 to
0c10bf4CompareUses the same clippy config as was added to the `cipher` crate in RustCrypto/traits#2279 Since `chacha20` defines `lints.rust.unexpected_cfgs` we have to define this at the crate-level rather than the workspace level, since if you use the latter it must hold all of the lint config. Fixes some violations, adds TODO and "needs triage" `allow()`s for others.
tarcieriforce-pushed
the
chacha20/clippy-config
branch
from
February 5, 2026 03:15
0c10bf4 to
96def56CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the same clippy config as was added to the
ciphercrate in RustCrypto/traits#2279Since
chacha20defineslints.rust.unexpected_cfgswe have to define this at the crate-level rather than the workspace level, since if you use the latter it must hold all of the lint config.Fixes some violations, adds TODO and "needs triage"
allow()s for others.